Remove _For_each_tuple_element in scoped_lock #760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scoped_lock::~scoped_lock uses _For_each_tuple_element which is not needed in C++17 because fold expressions can be used. This PR removes _For_each_tuple_element from tuple and changes the dtor in scoped_lock to use fold expression with std::apply. To minimize the changes in test (VSO_0000000_instantiate_containers) using _For_each_tuple_element, we copied this function to the test.
BillyONeal
reviewed
Apr 27, 2020
Address PR comments by adding _STD to scoped_lock::~scoped_lock() and make the functions in VSO_0000000_instantiate_containers/test.cpp not _Ugly.
CaseyCarter
approved these changes
Apr 28, 2020
Changing as per suggestion on PR review. Co-Authored-By: Casey Carter <cartec69@gmail.com>
StephanTLavavej
requested changes
Apr 28, 2020
StephanTLavavej
approved these changes
Apr 28, 2020
|
Thanks for this compiler throughput improvement! We've got unrelated test failures caused by other PRs colliding, so I went ahead and merged your PR with administrator powers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scoped_lock::~scoped_lock uses _For_each_tuple_element which is not
needed in C++17 because fold expressions can be used. This PR removes
_For_each_tuple_element from tuple and changes the dtor in scoped_lock
to use fold expression with std::apply.
To minimize the changes in test (VSO_0000000_instantiate_containers)
using _For_each_tuple_element, we copied this function to the test.
Closes #738