-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tests] Enable span tests now that libc++ has been updated #839
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Looks like other updates to the expected/skip lists are necessary, though.
So looking at this a bit I guess we should:
|
Yeah, it's easiest to restructure this test to avoid the warning.
Unskip - this is an XFAIL that now succeeds since someone finally looked at the PR I submitted last May.
This is testing UB by passing an insufficiently-complete type to You forgot "disable the bogus portion of the I pushed changes to skip/XFAIL these tests as appropriate, and submitted https://reviews.llvm.org/D80030 upstream to fix them. (Feel free to look and comment, but please don't approve or it will break their workflow and no one with approver powers will ever notice they need to look at it.) |
Thanks a lot for the help |
Thanks for updating libc++'s test coverage upstream and here - we really, really appreciate it! 😺 😸 😺 This will lower the "Libcxx Skips" line in the Status Chart too. |
It finally happened and the updates to std::span landed in libc++
Consequently we should now be able to use those tests.