Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update VMSS pool to one with vs16.7p2 #851

Merged
merged 4 commits into from
Jun 20, 2020

Conversation

cbezault
Copy link
Contributor

No description provided.

@cbezault cbezault added the infrastructure Related to repository automation label May 20, 2020
@cbezault cbezault requested a review from a team as a code owner May 20, 2020 21:46
@cbezault
Copy link
Contributor Author

I have no idea why edg isn't getting found :(.

@StephanTLavavej StephanTLavavej added the help wanted Extra attention is needed label May 27, 2020
@StephanTLavavej
Copy link
Member

I guess the next step to investigate is to prepare a VM with the script, and manually try to invoke cl /BE and see what happens?

@cbezault
Copy link
Contributor Author

Yup that would do it. You could also fuss around with making commits to this PR to do some debugging.

@AlexGuteniev
Copy link
Contributor

As there's p2 already, can you just try again with p2?

@cbezault
Copy link
Contributor Author

cbezault commented Jun 3, 2020

Sure

@cbezault cbezault changed the title Update VMSS pool to one with vs16.7p1 Update VMSS pool to one with vs16.7p2 Jun 3, 2020
@cbezault
Copy link
Contributor Author

cbezault commented Jun 3, 2020

Same problem

@cbezault
Copy link
Contributor Author

cbezault commented Jun 9, 2020

Looks like the CoreIde component doesn't exist anymore and we're silently failing when we provision the machines.
image

@StephanTLavavej
Copy link
Member

To make investigations easier in the future, when command-line install fails like this, are logs emitted anywhere (or can we add an option to request them)? I guess we could reproduce this at will any time by attempting to install a nonexistent component.

@cbezault
Copy link
Contributor Author

I think the problem with this one is that we need to pass --quiet to the VS installer in order to make it run unattended but when that happens no logs or other indicators are emitted. All we could do is check the installed packages after the fact and make sure they match what we expect.

Also Lukasz notes that this is probably due to us using the Build Tools SKU and it was just working by luck previously.

@StephanTLavavej
Copy link
Member

Use command-line parameters to install Visual Studio - Error codes says:

Each operation generates several log files in the %TEMP% directory that indicate the progress of the installation. Sort the folder by date and look for files that begin with dd_bootstrapper, dd_client, and dd_setup for the bootstrapper, the installer app, and the setup engine, respectively.

and doesn't say that --quiet suppresses them. Are log files being emitted there? If so, could we make the script echo them?

@BillyONeal
Copy link
Member

It doesn't matter if the script could echo them because we don't get any output from the script when run through Invoke-AzVmRunCommand

@BillyONeal
Copy link
Member

BillyONeal commented Jun 10, 2020

(I debugged issues like this by running the script in a (local) VM)

@cbezault cbezault self-assigned this Jun 10, 2020
@StephanTLavavej StephanTLavavej removed the help wanted Extra attention is needed label Jun 18, 2020
@cbezault cbezault assigned StephanTLavavej and unassigned cbezault Jun 18, 2020
@StephanTLavavej StephanTLavavej merged commit 42a8271 into microsoft:master Jun 20, 2020
@StephanTLavavej
Copy link
Member

Thanks for taking care of this update! I'll have to learn how to do the next one. 😸

ahanamuk pushed a commit to ahanamuk/STL that referenced this pull request Jun 25, 2020
ahanamuk pushed a commit to ahanamuk/STL that referenced this pull request Jun 26, 2020
ahanamuk pushed a commit to ahanamuk/STL that referenced this pull request Jun 29, 2020
ahanamuk pushed a commit to ahanamuk/STL that referenced this pull request Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
high priority Important! infrastructure Related to repository automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants