Implement ranges::_Ubegin and ranges::_Uend CPOs #901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...which call `_Unchecked_begin` and `_Unchecked_end` when present, and fall back to `_Get_unwrapped(begin(...))` (resp. `_Get_unwrapped(end(....))`) otherwise. Fixes microsoft#898.
CaseyCarter
commented
Jun 16, 2020
Casey's review feedback
|
I am slightly grumpy that I couldnt even find a nit. 👍 |
miscco
reviewed
Jun 16, 2020
StephanTLavavej
approved these changes
Jun 16, 2020
StephanTLavavej
approved these changes
Jun 17, 2020
barcharcraz
reviewed
Jun 18, 2020
mnatsuhara
approved these changes
Jun 18, 2020
barcharcraz
approved these changes
Jun 18, 2020
StephanTLavavej
changed the title
|
Thanks for making it easier to read the implementations of ranges algorithms! 🐈 |
ahanamuk
pushed a commit
to ahanamuk/STL
that referenced
this pull request
Jun 25, 2020
ahanamuk
pushed a commit
to ahanamuk/STL
that referenced
this pull request
Jun 26, 2020
ahanamuk
pushed a commit
to ahanamuk/STL
that referenced
this pull request
Jun 29, 2020
ahanamuk
pushed a commit
to ahanamuk/STL
that referenced
this pull request
Jul 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...which call
_Unchecked_beginand_Unchecked_endwhen present, and fall back to_Get_unwrapped(begin(...))(resp._Get_unwrapped(end(....))) otherwise.Fixes #898.