Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement ranges::generate and ranges::generate_n #905

Merged
merged 43 commits into from
Jul 11, 2020
Merged

Implement ranges::generate and ranges::generate_n #905

merged 43 commits into from
Jul 11, 2020

Conversation

ahanamuk
Copy link
Contributor

No description provided.

ahanamuk and others added 25 commits June 8, 2020 15:15
@ahanamuk
added the move algorithm on line 1265 of algorithm and created a new …
19c2a15 
…folder with test
@ahanamuk
added cmake file
354e48b
@ahanamuk
passing all tests for ranges move algorithm
09f6c9f
@ahanamuk
updated move algo tests to check that we actually move elems, not jus…
61375a9 
…t copy
@ahanamuk
enabled constexpr, cleaned up move algo test
68640ed
@ahanamuk
removed iostream unused header
5277552
@ahanamuk
mainly updated formatting/comments based on feedback
45fb14d
@ahanamuk
Delete cmake
80e349e
@ahanamuk
modified a test
d4f91b0
@ahanamuk
Merge branch 'move_algo' of https://github.com/ahanamuk/STL
a685197
@ahanamuk
initial fill algo
c9f134f
@ahanamuk
Passing all fill tests
93ff947
@ahanamuk
added a test case
be947f1
@ahanamuk
minor changes/formatting updates to move
5cb7bfc
@ahanamuk
updated clang formatting
9170077
@ahanamuk
initial fill algo
d4fbaac
@ahanamuk
comitting untracked stuff
064684e
@ahanamuk
generate initial commit
91040f9
@ahanamuk
minor changes
dd51ae0
@CaseyCarter
Merge branch 'master' into generate_algo
62689da
@ahanamuk
generate_n tests added
e2c8965
@ahanamuk
similar changes as casey made in fill_n
cc7220a
@ahanamuk
Merge pull request #2 from CaseyCarter/generate
f7cf046 
Ditto fix merge conflict for Generate
@ahanamuk
generate and generate_n tests passing now
e61aa5f
@ahanamuk
minor change
9c8acb3
@ahanamuk ahanamuk added the cxx20 C++20 feature label Jun 17, 2020
@ahanamuk ahanamuk requested a review from a team as a code owner June 17, 2020 16:05
@ghost
Copy link

ghost commented Jun 17, 2020 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

@CaseyCarter CaseyCarter mentioned this pull request Jun 17, 2020
Closed
StephanTLavavej
StephanTLavavej requested changes Jul 8, 2020
View reviewed changes
tests/std/include/range_algorithm_support.hpp Outdated Show resolved Hide resolved
stl/inc/algorithm Outdated Show resolved Hide resolved
tests/std/tests/P0896R4_ranges_alg_generate_n/test.cpp Outdated Show resolved Hide resolved
tests/std/tests/P0896R4_ranges_alg_generate_n/test.cpp Outdated Show resolved Hide resolved
tests/std/tests/P0896R4_ranges_alg_generate_n/test.cpp Outdated Show resolved Hide resolved
@StephanTLavavej StephanTLavavej added the ranges C++20/23 ranges label Jul 8, 2020
@CaseyCarter @StephanTLavavej
Apply suggestions from code review
40ddeac 
Co-authored-by: Stephan T. Lavavej <stl@nuwen.net>
@CaseyCarter CaseyCarter removed their assignment Jul 9, 2020
@mnatsuhara mnatsuhara mentioned this pull request Jul 10, 2020
Merged
@StephanTLavavej StephanTLavavej self-assigned this Jul 10, 2020
@StephanTLavavej StephanTLavavej merged commit ee6019d into microsoft:master Jul 11, 2020
@StephanTLavavej
Copy link
Member

Thanks for implementing these ranges algorithms, they're going to generate a lot of excitement. 😎

@miscco
Copy link
Contributor

miscco commented Jul 11, 2020

@CaseyCarter how did you hack into @StephanTLavavej's account?

@CaseyCarter
Copy link
Member

@CaseyCarter how did you hack into @StephanTLavavej's account?

I had the exact same thought - he's even using the sunglasses emoji instead of cat emoji! I feel seen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnatsuhara mnatsuhara mnatsuhara approved these changes

@miscco miscco miscco left review comments

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

@CaseyCarter CaseyCarter CaseyCarter approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
cxx20 C++20 feature ranges C++20/23 ranges
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ahanamuk @CaseyCarter @StephanTLavavej @miscco @mnatsuhara