-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More code cleanups in stl/src #912
Merged
StephanTLavavej
merged 21 commits into
microsoft:master
from
StephanTLavavej:more_cleanups
Jun 24, 2020
Merged
More code cleanups in stl/src #912
StephanTLavavej
merged 21 commits into
microsoft:master
from
StephanTLavavej:more_cleanups
Jun 24, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CaseyCarter
requested changes
Jun 23, 2020
mutex.cpp: Change 0 to nullptr, avoid elaborated-type-specifier, move definition to initialization. xwctomb.cpp: Move definition to initialization, add const.
CaseyCarter
approved these changes
Jun 23, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel free to note in the commit log that any breakage from removing the double reinterpret_cast
s is my fault ;)
BillyONeal
reviewed
Jun 23, 2020
BillyONeal
reviewed
Jun 23, 2020
BillyONeal
approved these changes
Jun 23, 2020
cbezault
approved these changes
Jun 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_tolower.cpp
,_toupper.cpp
,xwctomb.cpp
.static_cast
for arithmetic types.reinterpret_cast
for pointers.static_cast
fromvoid*
.malloc
etc., or restoring type information after going through avoid*
API. We've stylistically preferredstatic_cast
instead ofreinterpret_cast
in these scenarios.)static_cast<const char*>
whenmemchr()
returnsconst void*
. We don't need to cast awayconst
.wmemchr()
at all; its return type is already correct.reinterpret_cast
for_Dval*
/_Fval*
/_Lval*
(union type-punning for floating-point). Drop thereinterpret_cast<char*>
, which I believe was intended to prevent aliasing optimizations. Remove unnecessary parentheses afterwards. Useconst auto
(our new convention after a cast).const_cast
, required by the mismatched type ofendptr
._tolower.cpp
,const_cast<short*>
then implicitly convert tovoid*
.static_cast
andconst_cast
tolocale::facet*
inlocale.cpp
,wlocale.cpp
,xlocale.cpp
.xxxprec.h
, don't macroizeldexpf
/sqrtf
; the UCRT provides them.0
tonullptr
.primitives.h
, change__alignof
toalignof
.__max
yet.)filesys.cpp
, changewchar_t(0)
(which is technically a function-style cast) toL'\0'
.xstoul.cpp
, remove preprocessor logic becauseunsigned long
is always 32-bit on our platforms.locale.cpp
,wlocale.cpp
,xlocale.cpp
, use default template args and name typedefs consistently.locale0.cpp
.mutex.cpp
, avoid an elaborated-type-specifier (presumably a relic of when this was a C translation unit).