Not all interfaces should be marked as constructable

[mykhalov]

E.g. trying to call AbortSignal with new throws Illegal constructor error.

> new AbortSignal()
  Uncaught TypeError: Illegal constructor.

This is not currently handled by the declaration:

declare var AbortSignal: {
    prototype: AbortSignal;
    new(): AbortSignal;
};

[saschanaz]

This is because instanceof check requires a constructor member. But never seemingly works:

interface Foo {}

declare var Foo: {
    prototype: Foo;
    new(): never;
};

let foo = {} as Foo;
if (foo instanceof Foo) {
  foo // $Foo
}

@orta does new(): never make sense to fix this?

[orta]

We bounced the idea back and forth a bit, and generally think this is more likely to cause more breakages than it cures 👍🏻

[saschanaz]

cause more breakages than it cures

What breakages for example?

[aloisklink]

This also affects NodeList (which could have prevented a bug: mermaid-js/mermaid#3396)

Maybe it's worth putting in a /** @deprecated */ JSDoc tag to constructors that throw Illegal constructor, so some tools (like ESLint/VS Code) will warn about using them.

[saschanaz]

Sounds good to me but I wonder what TS team thinks about the suggestion, maybe @DanielRosenwasser?

[Skalman]

I just ran into this issue. Adding /** @deprecated */ seems like a good and simple fix.

What do you think, @DanielRosenwasser?

[saschanaz]

@sandersn Do you some context around #1162 (comment) ?