Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI #210

Closed
wants to merge 1 commit into from
Closed

Fix CI #210

wants to merge 1 commit into from

Conversation

zhengbli
Copy link
Contributor

No description provided.

@anubmat
Copy link
Contributor

anubmat commented Jul 15, 2016

👍

@anubmat
Copy link
Contributor

anubmat commented Jul 15, 2016

Is this simply an upgrade or does it also fix the build fail issue?

@zhengbli
Copy link
Contributor Author

zhengbli commented Jul 15, 2016 •
edited
Loading

It should fix it. The problem is that we should use npm@next for building node_gyp, see nodejs/node-gyp#972 (comment)

However the setting is actually done in appveyor settings, so this PR is not needed. Closing.

@zhengbli zhengbli closed this Jul 15, 2016
@sheetalkamat sheetalkamat deleted the fixCI branch July 12, 2023 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhengbli @anubmat @msftclas