Create the action only if the text change creation is successful. …

Make change for the infer type from usage could return undefined even if type is present if the type cannot be named Fixes #22184
microsoft · Mar 6, 2018 · 7094442 · 7094442
1 parent 6f6c401
commit 7094442
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/src/services/codefixes/inferFromUsage.ts b/src/services/codefixes/inferFromUsage.ts
@@ -186,7 +186,8 @@ namespace ts.codefix {
     }
 
     function makeFix(declaration: Declaration, start: number, type: Type | undefined, program: Program): Fix | undefined {
-        return type && { declaration, textChanges: [makeChange(declaration, start, type, program)] };
+        const change = makeChange(declaration, start, type, program);
+        return change && { declaration, textChanges: [change] };
     }
 
     function makeChange(declaration: Declaration, start: number, type: Type | undefined, program: Program): TextChange | undefined {

diff --git a/tests/cases/fourslash/codeFixInferFromUsageSetterWithInaccessibleType.ts b/tests/cases/fourslash/codeFixInferFromUsageSetterWithInaccessibleType.ts
@@ -13,4 +13,4 @@
 ////}
 
 goTo.file("/b.ts");
-verify.codeFixAvailable();
+verify.not.codeFixAvailable();