Skip caching for tail recursive temporary conditional types

microsoft · Sep 4, 2021 · a4224d6 · a4224d6
1 parent 093f76a
commit a4224d6
Showing 1 changed file with 10 additions and 12 deletions.
diff --git a/src/compiler/checker.ts b/src/compiler/checker.ts
@@ -15322,19 +15322,17 @@ namespace ts {
                     if (newRoot.outerTypeParameters) {
                         const typeParamMapper = combineTypeMappers((newType as ConditionalType).mapper, newMapper);
                         const typeArguments = map(newRoot.outerTypeParameters, t => getMappedType(t, typeParamMapper));
-                        if (!newRoot.instantiations!.get(getTypeListId(typeArguments))) {
-                            const newRootMapper = createTypeMapper(newRoot.outerTypeParameters, typeArguments);
-                            const newCheckType = newRoot.isDistributive ? getMappedType(newRoot.checkType, newRootMapper) : undefined;
-                            if (!newCheckType || newCheckType === newRoot.checkType || !(newCheckType.flags & (TypeFlags.Union | TypeFlags.Never))) {
-                                root = newRoot;
-                                mapper = newRootMapper;
-                                aliasSymbol = undefined;
-                                aliasTypeArguments = undefined;
-                                if (newRoot.aliasSymbol) {
-                                    tailCount++;
-                                }
-                                return true;
+                        const newRootMapper = createTypeMapper(newRoot.outerTypeParameters, typeArguments);
+                        const newCheckType = newRoot.isDistributive ? getMappedType(newRoot.checkType, newRootMapper) : undefined;
+                        if (!newCheckType || newCheckType === newRoot.checkType || !(newCheckType.flags & (TypeFlags.Union | TypeFlags.Never))) {
+                            root = newRoot;
+                            mapper = newRootMapper;
+                            aliasSymbol = undefined;
+                            aliasTypeArguments = undefined;
+                            if (newRoot.aliasSymbol) {
+                                tailCount++;
                             }
+                            return true;
                         }
                     }
                 }