Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unused span shouldn't cover 'function' keyword #24500

Closed
DanielRosenwasser opened this issue May 30, 2018 · 1 comment
Closed

Unused span shouldn't cover 'function' keyword #24500

DanielRosenwasser opened this issue May 30, 2018 · 1 comment
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue
Milestone
TypeScript 2.9.2

Comments

@DanielRosenwasser
Copy link
Member 

function area(shape) {
    throw shape;
}

'function' gets highlighted gray in my editor
@mhegazy
Copy link
Contributor

mhegazy commented May 30, 2018

We either should highlight the whole line, or only the identifier.

@mhegazy mhegazy added the Bug A bug in TypeScript label May 30, 2018
@mhegazy mhegazy assigned ghost May 30, 2018
@mhegazy mhegazy added this to the TypeScript 2.9.2 milestone May 30, 2018
@mjbvz mjbvz mentioned this issue May 31, 2018
Closed
@ghost ghost mentioned this issue Jun 1, 2018
Merged
@mhegazy mhegazy added the Fixed A PR has been merged for this issue label Jun 1, 2018
@ghost ghost closed this as completed in #24566 Jun 1, 2018
@microsoft microsoft locked and limited conversation to collaborators Jul 31, 2018
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue
Projects
None yet
Milestone
TypeScript 2.9.2
Development

No branches or pull requests
2 participants
@DanielRosenwasser @mhegazy