TS "function" color is changed when it's not used

[Tyriar]

Seems inconsistent with how variables work:

[ghost]

This is due to microsoft/TypeScript#22388 -- if it's not desired we could revert that.

[Tyriar]

@andy-ms I find it unexpected/distracting personally. This would probably drive me to disable it but I wanted to dogfood for a while longer 😄

[mjbvz]

@andy-ms Do you know what VS does for C#? Do they grey out just the symbol name:? The entire signature? Entire declaration?

[ghost]

@amcasey might know.

[amcasey]

I don't think C# reports it for functions. It's basically at the expression and statement levels.

[amcasey]

[amcasey]

The imports are grayed out, the cast is grayed out, and the unused local is squiggled (since it's a warning). Everything else is ignored. Of course, it may be that widely used analyzers report more aggressively.

[amcasey]

My personal preference would be to gray out the keyword (const in the original example) when all of the declared variables are unused. I think @andy-ms may have recently enabled this?

[mjbvz]

Yes I'd prefer this as well. Makes it more obvious that something is unused

[mjbvz]

Upstream issues for June: microsoft/TypeScript#24500

We decided to just color the symbol name (except for imports)

[ghost]

Should be fixed by microsoft/TypeScript#24566.

[mjbvz]

Fixed upstream in TS 2.9.2