-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make (no) space after type assertion user configurable #10402
Conversation
Hi @gnalck, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! TTYL, MSBOT; |
@gnalck, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR. |
@@ -1356,6 +1356,7 @@ namespace ts { | |||
InsertSpaceAfterOpeningAndBeforeClosingNonemptyBrackets: boolean; | |||
InsertSpaceAfterOpeningAndBeforeClosingTemplateStringBraces: boolean; | |||
InsertSpaceAfterOpeningAndBeforeClosingJsxExpressionBraces?: boolean; | |||
InsertSpaceAfterTypeAssertion: boolean; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be optional, otherwise all users of the API have to specify it.
@gnalck thanks for the PR, and extremely sorry for the delay. can you refresh the PR against master. modulo one comment, I think this PR is ready to go. |
manually merged. thanks! |
sweet, thanks! |
@mhegazy, @gnalck, hey guys, I'm super excited to use this feature in order to make the auto-format functionality compliant with my team's tslint rules. Unfortunately, I can't seem to set the insertSpaceAfterTypeAssertion option in my VSCode settings. It doesn't appear as an option and even if I manually enter it, the setting seems to have no effect: What am I missing here? Has this feature been officially released yet? |
@ydogandjiev I had asked the same in microsoft/vscode#10296 - glad to see that it got assigned to @mjbvz. Looking forward to this implemented, too! |
I have a trouble with this feature. with
no space is added after otherwise if i have
it correctly add a space after |
Fixes #10362