Formatting implementation using new tree #1109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n for end line position
| * { var x; | ||
| * } | ||
| * Normally indentation is applied only to the first token in line so at glance 'var' should not be touched. | ||
| * However if some format rule removes new line between ')' and '{' 'var' will become |
There was a problem hiding this comment.
i don't quite get this comment. "if some format rule removes new line between ')' and '{'" then we'll have:
while (true) { var x;
}
And 'var' will not be the first token in line.
There was a problem hiding this comment.
good catch. was thinking about another example with writing this comment, will make it more clear
| return find(sourceFile); | ||
|
|
||
| function find(n: Node): Node { | ||
| var candidate = forEachChild(n, c => startEndContainsRange(c.getStart(sourceFile), c.end, range) && c); |
There was a problem hiding this comment.
You might actually be able to make this faster if you fed in the optional cbNodes argument to perform a binary search.
vladima
added a commit
that referenced
this pull request
Nov 14, 2014
Formatting implementation using new tree
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds implementation of code formatting that works atop of new tree. I would not suggest to review the code commit-by-commit as intermediate checkins here often contain non-relevant details that are ultimately removed in final implementation.