Fix literal comparability in relational comparison operators #12158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to ===, except that it always applies, even when comparing two literals.
Literal types caused a bunch of errors that masked some changes in baselines. Getting rid of these errors causes the baselines to update again.
mhegazy
approved these changes
Nov 15, 2016
sandersn
deleted the
fix-literal-comparability-in-relational-comparison-operators
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10120
Now
<behaves like===, only more so. Literal types are always raised to their base before being compared, even if both sides are literal.The new test is relationalOperatorComparable.
Note that a ton of baselines changed because many tests errored when literal type comparability was first introduced. That means that their symbols and types became stale, so this PR has baseline changes that would have shown up in the meantime.