Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#13890 Implementing JSX.ElementType support #13891

Conversation

antanas-arvasevicius
Copy link

Implementing #13890. Code now for review and will add tests if this will be accepted at all.

@msftclas
Copy link

msftclas commented Feb 5, 2017

Hi @antanas-arvasevicius, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

@msftgits
Copy link

msftgits commented Feb 6, 2017

Hi, I am closing and re-opening this PR to bump the CLA bot. Sorry for the inconvenience!

@msftgits msftgits closed this Feb 6, 2017
@msftgits msftgits reopened this Feb 6, 2017
@msftclas
Copy link

msftclas commented Feb 6, 2017

Hi @antanas-arvasevicius, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
We will now validate the agreement and then real humans will evaluate your PR.

TTYL, MSBOT;

@antanas-arvasevicius antanas-arvasevicius force-pushed the jsx-element-type-support branch 2 times, most recently from 736d4b8 to 5231d21 Compare February 7, 2017 19:39
@antanas-arvasevicius
Copy link
Author

antanas-arvasevicius commented Feb 7, 2017

Hi, I've added conformance tests for all scenarios of JSX.ElementTypeProperty declarations.

@RyanCavanaugh
Copy link
Member

Per comments in #13890 and offline discussion, I think we want to go in the direction of #14729 as the next step here. I appreciate the work here but #14729 will be a broader solution to the problem, so hopefully we can take action on that at some point based on feedback and use cases.

@antanas-arvasevicius
Copy link
Author

No problem. Had a good time in exploring typescript internals and it's hard to believe that compiler's code can be read so nicely. It can be used as a teaching literature :-)

@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants