Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying the location of typingSafeList.json #14807

Merged
merged 2 commits into from
Mar 28, 2017

Conversation

minestarks
Copy link
Member

This is needed for VS to be able to use tsserver.js from an arbitrary location that may not have typingsafelist.json next to it.

@msftclas
Copy link

@minestarks,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@billti
Copy link
Member

billti commented Mar 28, 2017

The typingSafeList path is already provided via the language service API (see discoverTypings in shims.ts). Is it better provided via that API than on the command line?

@minestarks
Copy link
Member Author

@billti Maybe, but I can't figure out which message would pass the path then. The client (i.e. VS) doesn't call discoverTypings directly, tsserver decides when to do it.

@minestarks minestarks merged commit 711f62f into microsoft:master Mar 28, 2017
@minestarks minestarks deleted the typingsafelist branch March 28, 2017 21:28
@microsoft microsoft locked and limited conversation to collaborators Jun 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants