Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify parseTypeReference #15009

Merged
1 commit merged into from
Apr 5, 2017
Merged

Simplify parseTypeReference #15009

1 commit merged into from
Apr 5, 2017

Conversation

ghost
Copy link

@ghost ghost commented Apr 4, 2017

Create the node first, rather than creating it later and setting its pos to another node that was created first.

Create the node first, rather than creating it later and setting its pos to another node that was created first.
@sandersn
Copy link
Member

sandersn commented Apr 4, 2017

So pos isn't needed, or does finishNode set the pos based on children's span or something?

@ghost
Copy link
Author

ghost commented Apr 4, 2017

pos is set to the current position by default. If we create a node "too late" we may need to set it to an earlier position. But in this case we can create the node at the right point in time.

@ghost ghost merged commit 56510f1 into master Apr 5, 2017
@ghost ghost deleted the parseTypeReference branch April 5, 2017 14:15
@microsoft microsoft locked and limited conversation to collaborators Jun 21, 2018
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants