Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Covariant checking for callback parameters #15104

Merged
merged 9 commits into from
Apr 18, 2017
Merged

Covariant checking for callback parameters #15104

merged 9 commits into from
Apr 18, 2017

Commits on Apr 8, 2017

  1. Treat callback parameters as strictly covariant

    @ahejlsberg
    ahejlsberg committed Apr 8, 2017
    Configuration menu
    Copy the full SHA
    8ae3e05 View commit details
    Browse the repository at this point in the history

  2. Fix callback types to match covariantly

    @ahejlsberg
    ahejlsberg committed Apr 8, 2017
    Configuration menu
    Copy the full SHA
    eebd67f View commit details
    Browse the repository at this point in the history

  3. Accept new baselines

    @ahejlsberg
    ahejlsberg committed Apr 8, 2017
    Configuration menu
    Copy the full SHA
    11543d7 View commit details
    Browse the repository at this point in the history

  4. Add tests

    @ahejlsberg
    ahejlsberg committed Apr 8, 2017
    Configuration menu
    Copy the full SHA
    50f84b1 View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2017

  1. Check callback return values bi-variantly

    @ahejlsberg
    ahejlsberg committed Apr 10, 2017
    Configuration menu
    Copy the full SHA
    189fc51 View commit details
    Browse the repository at this point in the history

  2. Accept new baselines

    @ahejlsberg
    ahejlsberg committed Apr 10, 2017
    Configuration menu
    Copy the full SHA
    33bc9d1 View commit details
    Browse the repository at this point in the history

  3. Add another test case

    @ahejlsberg
    ahejlsberg committed Apr 10, 2017
    Configuration menu
    Copy the full SHA
    510bc81 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2017

  1. Allow callbacks unioned with null and/or undefined

    @ahejlsberg
    ahejlsberg committed Apr 11, 2017
    Configuration menu
    Copy the full SHA
    ec35b80 View commit details
    Browse the repository at this point in the history

  2. Update tests

    @ahejlsberg
    ahejlsberg committed Apr 11, 2017
    Configuration menu
    Copy the full SHA
    3cda0ea View commit details
    Browse the repository at this point in the history