Filter completion list according to meaning of the location #16206
Conversation
| @@ -954,7 +954,7 @@ var nodeServerInFile = "tests/webTestServer.ts"; | |||
| compileFile(nodeServerOutFile, [nodeServerInFile], [builtLocalDirectory, tscFile], [], /*useBuiltCompiler:*/ true, { noOutFile: true, lib: "es6" }); | |||
|
|
|||
| desc("Runs browserify on run.js to produce a file suitable for running tests in the browser"); | |||
| task("browserify", ["tests", builtLocalDirectory, nodeServerOutFile], function() { | |||
| task("browserify", ["tests", run, builtLocalDirectory, nodeServerOutFile], function() { | |||
There was a problem hiding this comment.
can you update the gulpfile as well?
There was a problem hiding this comment.
I have no clue what to update there
There was a problem hiding this comment.
I think on this line change [servicesFile] to [run, servicesFile] (or maybe [servicesFile, run]).
| //// var x1; | ||
| //// /*globalValue*/ | ||
|
|
||
| interface VeriferCompletionsInJsDoc { |
| /////*globalValue*/ | ||
| ////x./*valueMember*/ | ||
|
|
||
| interface VeriferCompletionsInJsDoc { |
| return true; | ||
| } | ||
|
|
||
| if (symbol.flags & (SymbolFlags.ValueModule | SymbolFlags.NamespaceModule)) { |
There was a problem hiding this comment.
if this is a NamespaceModule, why can not we just return true?
There was a problem hiding this comment.
Would show "m" in the completion even if it doesn't contain type or doesn't have any exported type. And user will get error with typing just m and there is nothing that can be dotted off. eg. namespace m { interface I {} }
There was a problem hiding this comment.
if it is un-instantiated, why cannot it be referenced in a type location? if it is, i understand we need to do the work to verify.
There was a problem hiding this comment.
because after typing var x : m. in above example there is nothing that can be shown so m is also not part of completion at var x:/*here*/
| @@ -1152,7 +1239,7 @@ namespace ts.Completions { | |||
| containingNodeKind === SyntaxKind.VariableDeclarationList || | |||
| containingNodeKind === SyntaxKind.VariableStatement || | |||
| containingNodeKind === SyntaxKind.EnumDeclaration || // enum a { foo, | | |||
| isFunction(containingNodeKind) || | |||
| isFunctionLikeButNotConstructor(containingNodeKind) || | |||
There was a problem hiding this comment.
Because that's not solely new identifier location (you can write modifiers etc)
src/services/completions.ts
Outdated
| } | ||
|
|
||
| function isContextTokenValueLocation(contextToken: Node) { | ||
| if (contextToken) { |
There was a problem hiding this comment.
return contextToken && contextToken.kind === SyntaxKind.TypeOfKeyword && contextToken.parent.kind === SyntaxKind.TypeQuery;
| return parentKind === SyntaxKind.TypeAliasDeclaration; | ||
|
|
||
| case SyntaxKind.AsKeyword: | ||
| return parentKind === SyntaxKind.AsExpression; |
There was a problem hiding this comment.
what about the other type assertion syntax?
There was a problem hiding this comment.
The TypeAssertion is anyways type node and the token < will have parent as type assertion and hence it will be type location any which ways. The tokens in as and var/property declarations are different because the parent declarations are value and hence need special handling
|
@sheetalkamat can you refresh the PR and merge |
|
waiting on tests. but once merged please port to release-2.4 |
|
@mhegazy the ci build passed(verified by checking out details as well) but it also shows typescript_node.6 test run failed and other two not started only. Don't know what it means. |
|
merged manually. we need to port this to release-2.4 |
Fixes #15750, #14285