Add 'isNamedDeclaration' helper to reduce casts #22089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -4298,6 +4298,11 @@ namespace ts { | |||
| return declaration.name || nameForNamelessJSDocTypedef(declaration); | |||
| } | |||
|
|
|||
| /** @internal */ | |||
| export function isNamedDeclaration(node: Node): node is NamedDeclaration & { name: DeclarationName } { | |||
There was a problem hiding this comment.
Mmm, this implementation doesn't seem to actually check that the name is a DeclarationName.
There was a problem hiding this comment.
Added an assertion -- a name property should always be a DeclarationName.
ghost
force-pushed
the
isNamedDeclaration
branch
from
1299534 to
b1c15f4
Compare
ghost
force-pushed
the
isNamedDeclaration
branch
from
b1c15f4 to
52d830f
Compare
mhegazy
reviewed
Feb 22, 2018
src/compiler/utilities.ts
Outdated
| /** @internal */ | ||
| export function isNamedDeclaration(node: Node): node is NamedDeclaration & { name: DeclarationName } { | ||
| const name = (node as NamedDeclaration).name; | ||
| Debug.assert(!name || isDeclaration(node) && node.name === name, "A 'name' property should always be a DeclarationName."); |
There was a problem hiding this comment.
this really a hot path, i would rather not do additional work. this is rather simple check. does it have a name property or not.
ghost
force-pushed
the
isNamedDeclaration
branch
from
96b9248 to
142824b
Compare
mhegazy
approved these changes
Mar 8, 2018
|
Hi. is this new Type Guard not exposed externally as all of the other Type Guards? |
|
You can send us a PR to remove the |
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Especially helps with #22088 because testing
(node as NamedDeclaration).namedoesn't make(node as NamedDeclaration).namedefined in future uses.