Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port changes from #22172, provide a callback to fs.close #22405

Merged
merged 1 commit into from
Mar 9, 2018
Merged

Port changes from #22172, provide a callback to fs.close #22405

merged 1 commit into from
Mar 9, 2018

Conversation

mhegazy
Copy link
Contributor

@mhegazy mhegazy commented Mar 8, 2018

Getting ready for node 10, see nodejs/node#18668 for more details.

Supersedes #22172

@mhegazy mhegazy requested review from sheetalkamat and a user March 8, 2018 18:30
@mhegazy mhegazy mentioned this pull request Mar 8, 2018
Closed
@mhegazy mhegazy merged commit 1fc3aeb into master Mar 9, 2018
@mhegazy mhegazy deleted the port22172 branch March 9, 2018 16:30
@mhegazy mhegazy mentioned this pull request Mar 9, 2018
Merged
@microsoft microsoft locked and limited conversation to collaborators Jul 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sheetalkamat sheetalkamat sheetalkamat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mhegazy @sheetalkamat