Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New vfs baselines follow-up #23878

Merged
merged 2 commits into from
May 3, 2018
Merged

New vfs baselines follow-up #23878

merged 2 commits into from
May 3, 2018

Conversation

rbuckton
Copy link
Member

@rbuckton rbuckton commented May 3, 2018

Per #20763 (comment), we opted to "patch" some of the paths used in the VFS PR to reduce the size of the PR and accept the baseline changes later. These are the baseline changes resulting from removing these "patches".

@mhegazy
Copy link
Contributor

mhegazy commented May 3, 2018

this will use lib.d.ts by default for tests, we opted to make the lib file smaller in tests to make sure we are not rechecking lib.d.ts all the time. what impact does this have on the test runtime?

@@ -1,3 +1,4 @@
// @lib: es5
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do so many tests now have an explicit // @lib: es5?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They contain declarations that conflict with declarations in dom. For those cases it was easier to just set the file to use lib.es5.d.ts.

@rbuckton
Copy link
Member Author

rbuckton commented May 3, 2018

I ran Measure-Command { gulp runtests-parallel } against master and oddly enough this was faster:

C:\dev\TypeScript [master]> gulp clean
...
C:\dev\TypeScript [master]> gulp tests
...
C:\dev\TypeScript [master]> Measure-Command { gulp runtests-parallel }
...
TotalSeconds      : 310.9653838
...


C:\dev\TypeScript [vfsBaselines]> gulp clean
...
C:\dev\TypeScript [vfsBaselines]> gulp tests
...
C:\dev\TypeScript [vfsBaselines]> Measure-Command { gulp runtests-parallel }
...
TotalSeconds      : 300.0299655
...

@weswigham
Copy link
Member

weswigham commented May 3, 2018

oddly enough this was faster

AFAIK we don't actually check the std libs we inject (unless added via the libFiles psuedo-compileroption) - we pull whatever's necessary to check the test. This PR removes a munch of errors from older baselines (by adjusting the lib they use); errors take time to generate, emit, and compare, so I'd wager that's where the difference lies.

@rbuckton rbuckton merged commit 4c6e93b into master May 3, 2018
@rbuckton rbuckton deleted the vfsBaselines branch May 3, 2018 23:35
@microsoft microsoft locked and limited conversation to collaborators Jul 31, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants