-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New vfs baselines follow-up #23878
New vfs baselines follow-up #23878
Conversation
this will use |
@@ -1,3 +1,4 @@ | |||
// @lib: es5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do so many tests now have an explicit // @lib: es5
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They contain declarations that conflict with declarations in dom
. For those cases it was easier to just set the file to use lib.es5.d.ts
.
I ran
|
AFAIK we don't actually check the std libs we inject (unless added via the |
Per #20763 (comment), we opted to "patch" some of the paths used in the VFS PR to reduce the size of the PR and accept the baseline changes later. These are the baseline changes resulting from removing these "patches".