Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better typings for promise.race based on conditional types #31117

Merged
merged 1 commit into from
Apr 30, 2019
Merged

Better typings for promise.race based on conditional types #31117

merged 1 commit into from
Apr 30, 2019

Conversation

RyanCavanaugh
Copy link
Member

Following the feature - Mapped tuple types #25947 - it is now possible to have better typings for Promise.race

From @dubzzz before I messed up his fork

@dubzzz @RyanCavanaugh
Better typings for promise.race based on mapped tuple types
7ee4e63 
Following the feature - Mapped tuple types microsoft#25947 - it is now possible to have better typings for Promise.race
@RyanCavanaugh RyanCavanaugh mentioned this pull request Apr 25, 2019
Closed
@DanielRosenwasser DanielRosenwasser changed the title Better typings for promise.race based on mapped tuple types Better typings for promise.race based on conditional types Apr 25, 2019
@DanielRosenwasser
Copy link
Member

This is thanks to conditional types, not mapped types.

It'd be nice to have a test of some sort (I'm sure we don't). Something simple like

let a = Promise.race([
    Promise.resolve(10),
    Promise.resolve("hello")
]);

@dubzzz
Copy link

dubzzz commented Apr 26, 2019

@DanielRosenwasser You're right. I think my first commit was really using mapped types but I changed it following reviews 🤔

@RyanCavanaugh
Copy link
Member Author

@typescript-bot test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Apr 30, 2019 •
edited
Loading

Heya @RyanCavanaugh, I've started to run the extended test suite on this PR at 7ee4e63. You can monitor the build here. It should now contribute to this PR's status checks.

@RyanCavanaugh RyanCavanaugh self-assigned this Apr 30, 2019
@RyanCavanaugh RyanCavanaugh merged commit d102ec0 into microsoft:master Apr 30, 2019
@RyanCavanaugh RyanCavanaugh deleted the dubzzz_port branch April 30, 2019 16:23
jablko added a commit to jablko/TypeScript that referenced this pull request Aug 23, 2019
@jablko
This Promise.race() overload moved to es2015.promise.d.ts in microsof…
b1b853c 
…t#31117
jablko added a commit to jablko/TypeScript that referenced this pull request Aug 23, 2019
@jablko
This Promise.race() overload moved to es2015.promise.d.ts in microsof…
effde01 
…t#31117
jablko added a commit to jablko/TypeScript that referenced this pull request Aug 23, 2019
@jablko
Better typings for Promise.all(), like microsoft#31117
1d79d5d 
Fixes microsoft#28427
jablko added a commit to jablko/TypeScript that referenced this pull request Aug 23, 2019
@jablko
Better typings for Promise.all(), like microsoft#31117
83331a3
jablko added a commit to jablko/TypeScript that referenced this pull request Aug 23, 2019
@jablko
Better typings for Promise executor, like microsoft#31117
5ab6100
jablko added a commit to jablko/TypeScript that referenced this pull request Aug 23, 2019
@jablko
Better typings for Promise executor, like microsoft#31117
3476da2
jablko added a commit to jablko/TypeScript that referenced this pull request Aug 25, 2019
@jablko
Better typings for Promise.resolve(), like microsoft#31117
2c5d22e
jablko added a commit to jablko/TypeScript that referenced this pull request Aug 25, 2019
@jablko
Better typings for Promise.resolve(), like microsoft#31117
55c362c
jablko added a commit to jablko/TypeScript that referenced this pull request Aug 25, 2019
@jablko
Better typings for Promise.resolve(), like microsoft#31117
5061d7d
jablko added a commit to jablko/TypeScript that referenced this pull request Aug 25, 2019
@jablko
This Promise.race() overload moved to es2015.promise.d.ts in microsof…
5c96bc8 
…t#31117
jablko added a commit to jablko/TypeScript that referenced this pull request Aug 25, 2019
@jablko
Better typings for Promise.all(), like microsoft#31117
74c5c63
jablko added a commit to jablko/TypeScript that referenced this pull request Aug 25, 2019
@jablko
Better typings for Promise.resolve(), like microsoft#31117
d5b8656
jablko added a commit to jablko/TypeScript that referenced this pull request Aug 27, 2019
@jablko
Better typings for Promise executor, like microsoft#31117
1f6d527
jablko added a commit to jablko/TypeScript that referenced this pull request Aug 27, 2019
@jablko
Better typings for Promise.then(), like microsoft#31117
5774cd3
jablko added a commit to jablko/TypeScript that referenced this pull request Aug 27, 2019
@jablko
Better typings for Promise.then(), like microsoft#31117
75ac22d
jablko added a commit to jablko/TypeScript that referenced this pull request Aug 27, 2019
@jablko
Better typings for AsyncIterator/Generator, like microsoft#31117
31c9cfc
jablko added a commit to jablko/TypeScript that referenced this pull request Aug 27, 2019
@jablko
Better typings for AsyncIterator/Generator, like microsoft#31117
a4fc119
jablko added a commit to jablko/TypeScript that referenced this pull request Aug 27, 2019
@jablko
Better typings for Promise.then(), like microsoft#31117
fb7d414
jablko added a commit to jablko/TypeScript that referenced this pull request Aug 29, 2019
@jablko
This Promise.race() overload moved to es2015.promise.d.ts in microsof…
29f81fc 
…t#31117
jablko added a commit to jablko/TypeScript that referenced this pull request Aug 29, 2019
@jablko
Better typings for Promise.all(), like microsoft#31117
73dad13
jablko added a commit to jablko/TypeScript that referenced this pull request Feb 12, 2020
@jablko
Move this Promise.race() overload back to es2015.iterable.d.ts
80906c6 
You can include es2015.promise.d.ts without es2015.iterable.d.ts. It was
moved to es2015.promise.d.ts in microsoft#31117
jablko added a commit to jablko/TypeScript that referenced this pull request Feb 12, 2020
@jablko
Better typings for Promise.all(), like microsoft#31117
7cceb79
jablko added a commit to jablko/TypeScript that referenced this pull request Feb 12, 2020
@jablko
Better typings for Promise.resolve(), like microsoft#31117
bb11033
jablko added a commit to jablko/TypeScript that referenced this pull request Feb 13, 2020
@jablko
Better typings for Promise.then(), like microsoft#31117
de6284c
jablko added a commit to jablko/TypeScript that referenced this pull request Feb 13, 2020
@jablko
Move this Promise.race() overload back to es2015.iterable.d.ts
e68700b 
You can include es2015.promise.d.ts without es2015.iterable.d.ts. It was
moved to es2015.promise.d.ts in microsoft#31117
jablko added a commit to jablko/TypeScript that referenced this pull request Feb 13, 2020
@jablko
Better typings for Promise.all(), like microsoft#31117
5dc69a1
jablko added a commit to jablko/TypeScript that referenced this pull request Feb 13, 2020
@jablko
Better typings for Promise.resolve(), like microsoft#31117
7e75928
jablko added a commit to jablko/TypeScript that referenced this pull request Feb 13, 2020
@jablko
Move this Promise.race() overload back to es2015.iterable.d.ts
b93ffb5 
You can include es2015.promise.d.ts without es2015.iterable.d.ts. It was
moved to es2015.promise.d.ts in microsoft#31117
jablko added a commit to jablko/TypeScript that referenced this pull request Feb 13, 2020
@jablko
Move this Promise.race() overload back to es2015.iterable.d.ts
c14905e 
You can include es2015.promise.d.ts without es2015.iterable.d.ts. It was
moved to es2015.promise.d.ts in microsoft#31117
jablko added a commit to jablko/TypeScript that referenced this pull request Feb 13, 2020
@jablko
Better typings for Promise.all(), like microsoft#31117
cda17cd
jablko added a commit to jablko/TypeScript that referenced this pull request Feb 21, 2020
@jablko
Better typings for Promise.then(), like microsoft#31117
a96a831
jablko added a commit to jablko/TypeScript that referenced this pull request Feb 21, 2020
@jablko
Better typings for Promise.resolve(), like microsoft#31117
df1c5e1
jablko added a commit to jablko/TypeScript that referenced this pull request Feb 21, 2020
@jablko
Move this Promise.race() overload back to es2015.iterable.d.ts
1e8aeb0 
You can include es2015.promise.d.ts without es2015.iterable.d.ts. It was
moved to es2015.promise.d.ts in microsoft#31117
jablko added a commit to jablko/TypeScript that referenced this pull request Feb 21, 2020
@jablko
Better typings for Promise.all(), like microsoft#31117
eccb4a4
jablko added a commit to jablko/TypeScript that referenced this pull request Feb 21, 2020
@jablko
Move this Promise.race() overload back to es2015.iterable.d.ts
6ba95ea 
You can include es2015.promise.d.ts without es2015.iterable.d.ts. It was
moved to es2015.promise.d.ts in microsoft#31117
jablko added a commit to jablko/TypeScript that referenced this pull request Feb 21, 2020
@jablko
Better typings for Promise.all(), like microsoft#31117
d25539d
jablko added a commit to jablko/TypeScript that referenced this pull request Feb 21, 2020
@jablko
Move this Promise.race() overload back to es2015.iterable.d.ts
f8f778d 
You can include es2015.promise.d.ts without es2015.iterable.d.ts. It was
moved to es2015.promise.d.ts in microsoft#31117
jablko added a commit to jablko/TypeScript that referenced this pull request Feb 22, 2020
@jablko
Move this Promise.race() overload back to es2015.iterable.d.ts
8381658 
You can include es2015.promise.d.ts without es2015.iterable.d.ts. It was
moved to es2015.promise.d.ts in microsoft#31117
jablko added a commit to jablko/TypeScript that referenced this pull request Feb 22, 2020
@jablko
Better typings for Promise.all(), like microsoft#31117
4544384
jablko added a commit to jablko/TypeScript that referenced this pull request Feb 22, 2020
@jablko
Better typings for Promise.resolve(), like microsoft#31117
ac40498
jablko added a commit to jablko/TypeScript that referenced this pull request Feb 22, 2020
@jablko
Move this Promise.race() overload back to es2015.iterable.d.ts
e9a1dae 
You can include es2015.promise.d.ts without es2015.iterable.d.ts. It was
moved to es2015.promise.d.ts in microsoft#31117
jablko added a commit to jablko/TypeScript that referenced this pull request Feb 22, 2020
@jablko
Move this Promise.race() overload back to es2015.iterable.d.ts
3209533 
You can include es2015.promise.d.ts without es2015.iterable.d.ts. It was
moved to es2015.promise.d.ts in microsoft#31117
jablko added a commit to jablko/TypeScript that referenced this pull request Feb 22, 2020
@jablko
Better typings for Promise.all(), like microsoft#31117
d40db09
jablko added a commit to jablko/TypeScript that referenced this pull request Feb 22, 2020
@jablko
Better typings for Promise.then(), like microsoft#31117
5535587
@dubzzz dubzzz mentioned this pull request Jun 13, 2020
Closed
rbuckton pushed a commit to jablko/TypeScript that referenced this pull request Mar 18, 2022
@jablko @rbuckton
Better typings for Promise.resolve(), like microsoft#31117
88254eb
rbuckton added a commit that referenced this pull request Aug 2, 2022
@jablko @rbuckton
Better typings for Promise.resolve(), like #31117 (#33074)
040c121 
* Better typings for Promise.resolve(), like #31117

* Add tests

* Update to Awaited<T>

* Fix issue with Awaited affecting jQuery, additional tests

Co-authored-by: Ron Buckton <ron.buckton@microsoft.com>
sandersn added a commit that referenced this pull request Aug 8, 2022
@sandersn
Revert "Better typings for Promise.resolve(), like #31117 (#33074)"
c28ee65 
This reverts commit 040c121.
typescript-bot pushed a commit to typescript-bot/TypeScript that referenced this pull request Aug 9, 2022
@sandersn @typescript-bot
Cherry-pick PR microsoft#50227 into release-4.8
542f17b 
Component commits:
c28ee65 Revert "Better typings for Promise.resolve(), like microsoft#31117 (microsoft#33074)"
This reverts commit 040c121.
typescript-bot pushed a commit to typescript-bot/TypeScript that referenced this pull request Aug 11, 2022
@sandersn
Cherry-pick PR microsoft#50227 into release-4.8 (microsoft#50229)
d2e2941 
Component commits:
c28ee65 Revert "Better typings for Promise.resolve(), like microsoft#31117 (microsoft#33074)"
This reverts commit 040c121.

Co-authored-by: Nathan Shively-Sanders <nathansa@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@RyanCavanaugh RyanCavanaugh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@RyanCavanaugh @DanielRosenwasser @dubzzz @typescript-bot @buu700