-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Variadic tuple types #39094
Variadic tuple types #39094
Conversation
# Conflicts: # src/compiler/checker.ts # tests/baselines/reference/callWithSpread3.errors.txt # tests/baselines/reference/genericRestParameters1.errors.txt # tests/baselines/reference/ramdaToolsNoInfinite.types
Will the type of |
That's a very good example of something that can easily be improved by using this. Maybe someone should raise an issue or create a pull request for it. |
It's already discussed in #39788 |
With #41544 we now support rest elements in starting and middle positions of tuple types. This addresses some of the issues that were discussed in this PR, such as #39094 (comment). |
Summary: Problem: To solve `Tuple[int, str, bool, bool] <: Tuple[int, *Ts, int]`, we need to solve `[int, str, bool, bool] <: [int, *Ts, int]`. We do that by removing matching elements of known length from both the prefix and the suffix. In the above example, `int` is in both prefixes, so we extract it. Next, the left side has `str`, which has a known fixed length 1, but the right side has `*Ts`, which doesn't have a known length. So, we don't extract that. Likewise, we can extract the matching suffix of `[bool] vs [int]` since they have known lengths. (We just split by lengths here, without checking for compatibility. That happens in `solve`.) So, after splitting, we get ``` [int] - [str, bool] - [bool] [int] - [ *Ts ] - [int] ``` We solve each part pairwise. We check `int <: int`, `[str, bool] <: [*Ts]`, and `bool <: int`. So, we end up solving it as `Ts = Tuple[str, bool]`. There are other cases like unbounded tuples, bound vs free variables, multiple `*Ts`, and so on, but this is the core idea. This is what TypeScript [does](microsoft/TypeScript#39094) for its variadic tuples. Note that we don't yet support unpacking unbounded tuples or concatenation of multiple variadics (that's in a future PEP). Reviewed By: grievejia Differential Revision: D26520882 fbshipit-source-id: 0df0d74becf3ee2a85caf3819093ccc336a5029d
This PR implements variadic tuple types, i.e. the ability for tuple types to have spreads of generic types that can be replaced with actual elements through type instantiation. The PR effectively implements the features discussed in #5453.
Some examples of new capabilities provided in this PR:
Structure and instantiation
The basic structure of a non-generic tuple type remains unchanged with this PR: Zero or more required elements, followed by zero or more optional elements, optionally followed by a rest element (for example
[A, B?, ...C[]]
). However, it is now possible to have variadic elements anywhere in a tuple type, except following the optional rest element (for example[A, ...T, B?, ...U, ...C[]]
).A variadic elemement is a spread element of the form
...T
, whereT
is a generic type constrained to any array or tuple type (specifically, any type that is assignable toreadonly any[]
). Intuitively, a variadic element...T
is a placeholder that is replaced with one or more elements through generic type instantiation. Instantiation of a tuple type with a variadic element...T
depends on the type argument provided forT
as follows:T
is a union type, the union is spread over the tuple type. For example,[A, ...T, B]
instantiated withX | Y | Z
as the type argument forT
yields a union of instantiations of[A, ...T, B]
withX
,Y
andZ
as the type argument forT
respectively.T
is replaced with the elements of that tuple type. For example,[A, ...T, B]
instantiated with[X, Y]
as the type argument forT
yields[A, X, Y, B]
.T
is replaced with a rest element. For example,[A, ...T]
instantiated withX[]
as the type argument forT
yields[A, ...X[]]
.T
is simply replaced with that type.any
,T
is replaced with...any[]
.never
, the entire result isnever
.Instantiation of a generic tuple type includes normalization to ensure the resulting tuple type follows the basic structure described above. Specifically:
[A?, ...T, B?]
instantiated with[X, Y?]
as the type argument forT
yields[A, X, Y?, B?]
.[A, ...T, B]
instantiated withX[]
as the type argument forT
yields[A, ...(X | B)[]]
.[...X[]]
is reduced to simplyX[]
.NOTE: With #41544 we now support starting and middle rest elements in tuple types.
Type relationships
Generally, a tuple type
S
is related to a tuple typeT
by pairwise relating elements ofS
to the elements ofT
. Variadic elements are processed as follows:...U
inS
is related to a variadic element...V
inT
ifU
is related toV
....U
inS
is related to a rest element...X[]
inT
ifU
is related toX[]
.Some examples:
Tuple types with single variadic elements have the following relations:
[...T]
is related toT
.T
is related toreadonly [...T]
.T
is related to[...T]
whenT
is constrained to a mutable array or tuple type.Some examples:
Type inference
Inference between tuple types with the same structure (i.e. same number of elements and fixed, variadic, or rest kind matched to the same kind in each position), simply infers pairwise between the element types. For example, inference from
[string, ...Partial<S>, number?]
to[string, ...T, number?]
infersPartial<S>
forT
.Inference between tuple types
S
andT
with different structure divides each tuple into a starting fixed part, a middle part, and an ending fixed part. Any one of these parts may be empty.The starting fixed parts of
S
andT
consist of those elements inS
andT
that are fixed (i.e. neither variadic nor rest elements) in both types matching from the start of each type.If
T
contains at least one variadic element andS
has no ending rest element, the ending fixed parts ofS
andT
consist of those elements inS
andT
that are fixed in both types matching from the end of each type.If
T
contains at least one variadic element andS
has an ending rest element, the ending fixed part ofT
consists of those elements inT
that are fixed matching from the end of the type, and the ending fixed part ofS
is empty.If
T
contains no variadic elements, the ending fixed parts ofS
andT
are empty.The middle parts of
S
andT
are those elements inS
andT
that remain between the starting and ending fixed parts of the types respectively.Inference then proceeds as follows:
Pairwise infer between the elements in the starting parts.
If the middle part of
S
is a single rest element, infer from that rest element to every element in the middle part ofT
.If the middle part of
T
is a single variadic or rest element, infer from a tuple consisting of the middle part ofS
to that variadic or rest element.If the middle part of
T
is exactly two variadic elements...A
and...B
, and an implied arity exists forA
, infer from a tuple consisting of the initial middle part ofS
toA
and from a tuple consisting of the remaining middle part ofS
toB
, where the length of the initial middle part corresponds to the implied arity forA
.Pairwise infer between the elements in the ending parts, or infer from the rest element in
S
to the elements of the ending part ofT
.In the context of inference for a call of a generic function with a rest parameter
R
, the implied arity forR
is the number of rest arguments supplied forR
. In all other contexts, a type parameter has no implied arity. For an example of inference involving an implied arity, see thecurry
function in the introduction.Some examples:
Spreads in array literals
When an array literal has a tuple type, a spread of a value of a generic array-like type produces a variadic element. For example:
When the contextual type of an array literal is a tuple type, a tuple type is inferred for the array literal. The type
[...T]
, whereT
is an array-like type parameter, can conveniently be used to indicate a preference for inference of tuple types:Indexing and destructuring
Indexing and destructuring of generic tuple types appropriately recognizes fixed elements at the start of the tuple type. Beyond the fixed elements, the type is simply a union of the remaining element types.
Rest parameters and spread arguments
Spread expressions with fixed length tuples are now appropriately flattened in argument lists. For example:
A rest parameter of a generic tuple type can be used to infer types from the middle part of argument lists. For example:
Application of mapped types
When a mapped type is applied to a generic tuple type, non-variadic elements are eagerly mapped but variadic elements continue to be generic. Effectively,
M<[A, B?, ...T, ...C[]]
is resolved as[...M<[A]>, ...M<[B?]>, ...M<T>, ...M<C[]>]
. For example:Fixes #5453.
Fixes #26113.