Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Insert auto imports after header comment #39924

Merged
merged 2 commits into from
Aug 6, 2020
Merged

Insert auto imports after header comment #39924

merged 2 commits into from
Aug 6, 2020

Conversation

jessetrinity
Copy link
Contributor

Fixes #39922

@typescript-bot typescript-bot added the For Milestone Bug PRs that fix a bug with a specific milestone label Aug 5, 2020
andrewbranch
andrewbranch requested changes Aug 5, 2020
View reviewed changes
src/services/textChanges.ts Outdated Show resolved Hide resolved
src/services/utilities.ts Outdated Show resolved Hide resolved
andrewbranch
andrewbranch approved these changes Aug 5, 2020
View reviewed changes
Copy link
Member

@andrewbranch andrewbranch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! 🎉

@DanielRosenwasser
Copy link
Member

Just as a heads up, your commits don't seem to be associated with your GitHub account. While this isn't technically a problem, you might care if you want more appropriate attribution. You can either make sure your GitHub account is associated with the email address that you're using for your commits, or rebase and amend your commits to fix the author name and email.

@jessetrinity
Copy link
Contributor Author

I do have an email address associated with my github account and it is verified. I do have "keep my email address private checked."

I'm not 100% what the issue is.

@andrewbranch
Copy link
Member

Commits look associated to me?

@andrewbranch
Copy link
Member

@DanielRosenwasser are you referring to the GPG-signed indicator (the “Verified” badge)?

@jessetrinity jessetrinity merged commit 91a7c35 into microsoft:master Aug 6, 2020
@uniqueiniquity
Copy link
Contributor

@typescript-bot cherry-pick this to release-4.0

@typescript-bot
Copy link
Collaborator

typescript-bot commented Sep 16, 2020 •
edited
Loading

Heya @uniqueiniquity, I've started to run the task to cherry-pick this into release-4.0 on this PR at d35d719. You can monitor the build here.

@typescript-bot typescript-bot mentioned this pull request Sep 16, 2020
Merged
@typescript-bot
Copy link
Collaborator

Hey @uniqueiniquity, I've opened #40595 for you.

typescript-bot pushed a commit to typescript-bot/TypeScript that referenced this pull request Sep 16, 2020
@jessetrinity @typescript-bot
Cherry-pick PR microsoft#39924 into release-4.0
e3301f7 
Component commits:
45d9eb5 place first import after header

d35d719 don't insert before non-header
uniqueiniquity added a commit that referenced this pull request Sep 16, 2020
@uniqueiniquity
Merge pull request #40595 from typescript-bot/pick/39924/release-4.0
1dde4bb 
🤖 Pick PR #39924 (Insert auto imports after header co...) into release-4.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewbranch andrewbranch andrewbranch approved these changes

Assignees

@jessetrinity jessetrinity

Labels
Author: Team For Milestone Bug PRs that fix a bug with a specific milestone
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

auto-import inserts new import before first comment
5 participants
@jessetrinity @DanielRosenwasser @andrewbranch @uniqueiniquity @typescript-bot