Reuse input nodes where possible when serializing jsdoc implements clauses #41783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Milestone Bug
weswigham
force-pushed
the
implements-jsdoc-type-params
branch
from
6e9b462
to
d5280d0
Compare
sandersn
requested changes
Dec 4, 2020
| return cleanup(/*result*/ undefined); | ||
| } | ||
| } | ||
| return cleanup(factory.createExpressionWithTypeArguments(expr, map(e.typeArguments, a => serializeExistingTypeNode(context, a, includePrivateSymbol, bundled) || typeToTypeNodeHelper(getTypeFromTypeNode(a), context)))); |
There was a problem hiding this comment.
I'm not sure this is the best way to break up this line, but it's what I ended up doing so I could read it.
Suggested change
| return cleanup(factory.createExpressionWithTypeArguments(expr, map(e.typeArguments, a => serializeExistingTypeNode(context, a, includePrivateSymbol, bundled) || typeToTypeNodeHelper(getTypeFromTypeNode(a), context)))); | |
| return cleanup(factory.createExpressionWithTypeArguments(expr, | |
| map(e.typeArguments, a => | |
| serializeExistingTypeNode(context, a, includePrivateSymbol, bundled) | |
| || typeToTypeNodeHelper(getTypeFromTypeNode(a), context)))); |
| return cleanup(factory.createExpressionWithTypeArguments(expr, map(e.typeArguments, a => serializeExistingTypeNode(context, a, includePrivateSymbol, bundled) || typeToTypeNodeHelper(getTypeFromTypeNode(a), context)))); | ||
|
|
||
| function cleanup<T>(result: T): T { | ||
| context.enclosingDeclaration = oldEnclosing; |
There was a problem hiding this comment.
I mean... try...finally is that, but has bad perf implications last I checked.
There was a problem hiding this comment.
that gives you the control flow, but not the scoping behaviour for variables. I'm talking something like special in Common Lisp, which would allow the assignment to context.enclosingDeclaration on line 6733 to be popped off the stack at the end of the scope instead of requiring the oldEnclosing=context.enclosing/context.enclosing=oldEnclosing bracketing to be manually written.
| const localParams = getLocalTypeParametersOfClassOrInterfaceOrTypeAlias(symbol); | ||
| const typeParamDecls = map(localParams, p => typeParameterToDeclaration(p, context)); | ||
| const classType = getDeclaredTypeOfClassOrInterface(symbol); | ||
| const baseTypes = getBaseTypes(classType); | ||
| const implementsExpressions = mapDefined(getImplementsTypes(classType), serializeImplementedType); | ||
| const originalImplements = originalDecl && getEffectiveImplementsTypeNodes(originalDecl); | ||
| const implementsExpressions = originalImplements && sanitizeJSDocImplements(originalImplements) || mapDefined(getImplementsTypes(classType), serializeImplementedType); |
There was a problem hiding this comment.
might be nice to break this line too
sandersn
approved these changes
Dec 5, 2020
andrewbranch
approved these changes
Dec 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #41258