getEditsForFileRename: fix updateTsconfigFiles w/ empty include
#44484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Milestone Bug
sandersn
approved these changes
Jun 18, 2021
Avoid the assumption that there are always include patterns: when there are none (and therefore the renamed file didn't match anyway), just skip the test for added include. Also change the code to use `return` to make it flatter. (Also get rid of a redundant type.) Fixes microsoft#40386.
| } | ||
| if (foundExactMatch || propertyName !== "include" || !isArrayLiteralExpression(property.initializer)) return; | ||
| const includes = mapDefined(property.initializer.elements, e => isStringLiteral(e) ? e.text : undefined); | ||
| if (includes.length === 0) return; |
There was a problem hiding this comment.
Is this the only meaningful diff in this file (e.g. all the other changes are supposed to be functionally-equivalent) ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid the assumption that there are always include patterns: when there
are none (and therefore the renamed file didn't match anyway), just skip
the test for added include.
Also change the code to use
returnto make it flatter.(Also get rid of a redundant type.)
Fixes #40386.