Fixed an issue with an incorrect resolved signature being cached/returned sometimes for signatures depending on the contextual type/outer inference #52146
Conversation
…rned sometimes for signatures depending on the contextual type/outer inference
There was a problem hiding this comment.
This approach seems fine to me; there's probably some other detritus in the caches when the inner resolution of the signature proceeds differently than the outer one in cases like this - cached expression types for context-sensitive expressions during the inner signature resolution may take priority, and thus affect other checking down the line (see how we get string in the inference for the call to $ but "foo" in the inference to m? Yeah. That.)... But I think this is fairy low-impact as-is, even if it can't fix all potential knock-on effects of a recursive signature resolution, it'll at least get the signature error state more consistently aligned.
So there's probably more to fix down this rabbithole, but I think this is a decent start and pretty low risk. I'll run DT and, should that come back fine, merge this.
|
@typescript-bot run dt |
|
Heya @weswigham, I've started to run the parallelized Definitely Typed test suite on this PR at bf1ba58. You can monitor the build here. Update: The results are in! Update: The results are in! |
|
Hey @weswigham, it looks like the DT test run failed. Please check the log for more details. |
|
I hit rerun on the above one too, but if that doesn't work we can just rerun it from scratch again. |
|
Hey @weswigham, it looks like the DT test run failed. Please check the log for more details. |
|
@typescript-bot run dt |
|
Heya @jakebailey, I've started to run the parallelized Definitely Typed test suite on this PR at bf1ba58. You can monitor the build here. Update: The results are in! |
|
Hey @jakebailey, it looks like the DT test run failed. Please check the log for more details. |
|
@typescript-bot run dt and dodge the npm race crash this time thanks |
|
Heya @weswigham, I've started to run the parallelized Definitely Typed test suite on this PR at bf1ba58. You can monitor the build here. Update: The results are in! |
|
Hey @weswigham, the results of running the DT tests are ready. |
fixes #44879
Reproduction scenario - hover over call to
$before hovering over the call tom: TS playground.Interestingly, it stopped being reproducible like this in 4.7: TS playground. I think this was fixed by #36747 . However, following the exact same scenario using the test utils in the codebase still reproduce the issue - so it could resurface any time and it means that it somehow depends on what the TS server (or something) is doing now. The test utils do the bare minimum so it's easy to reproduce it there.