Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from corepack to a global npm install for now #54578

Merged
merged 2 commits into from
Jun 8, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,9 @@ jobs:
node-version: "*"
check-latest: true
- run: |
corepack enable npm
npm --version
# corepack enable npm
npm install -g $(jq -r '.packageManager' < package.json)
npm --version

- run: npm ci
Expand Down Expand Up @@ -153,8 +155,13 @@ jobs:
node-version: "*"
check-latest: true
- run: |
corepack enable npm
npm --version
# corepack enable npm

- run: |
npm install -g $(jq -r '.packageManager' < package.json)
npm --version
working-directory: ./pr

- run: npm ci
working-directory: ./pr
Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/new-release-branch.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,9 @@ jobs:
steps:
- uses: actions/setup-node@v3
- run: |
corepack enable npm
npm --version
# corepack enable npm
npm install -g $(jq -r '.packageManager' < package.json)
npm --version
- uses: actions/checkout@v3
with:
Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/nightly.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,9 @@ jobs:
# Use NODE_AUTH_TOKEN environment variable to authenticate to this registry.
registry-url: https://registry.npmjs.org/
- run: |
corepack enable npm
npm --version
# corepack enable npm
npm install -g $(jq -r '.packageManager' < package.json)
npm --version
- name: Setup and publish nightly
run: |
Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/release-branch-artifact.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,9 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
- run: |
corepack enable npm
npm --version
# corepack enable npm
npm install -g $(jq -r '.packageManager' < package.json)
npm --version
- name: npm install and test
run: |
Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/set-version.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,9 @@ jobs:
with:
ref: ${{ github.event.client_payload.branch_name }}
- run: |
corepack enable npm
npm --version
# corepack enable npm
npm install -g $(jq -r '.packageManager' < package.json)
npm --version
# notably, this is essentially the same script as `new-release-branch.yaml` (with fewer inputs), but it assumes the branch already exists
# do note that executing the transform below will prevent the `configurePrerelease` script from running on the source, as it makes the
Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/update-package-lock.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,9 @@ jobs:
with:
node-version: 16
- run: |
corepack enable npm
npm --version
# corepack enable npm
npm install -g $(jq -r '.packageManager' < package.json)
npm --version

- name: Update package-lock.json and push
Expand Down