[Interactive inlay hints] Get source file from parameter node #55476

MariaSolOs · 2023-08-23T00:24:34Z

Fixes #55474

DanielRosenwasser

Looks good, but you need a test case.

src/server/session.ts

MariaSolOs · 2023-08-23T00:58:55Z

Looks good, but you need a test case.

Yep, I was going to publish it once I added that.

tests/cases/fourslash/inlayHintsInteractiveMultifileFunctionCalls.ts

DanielRosenwasser · 2023-08-23T18:38:43Z

tests/cases/fourslash/inlayHintsInteractiveMultifileFunctionCalls.ts

+verify.baselineInlayHints(undefined, {
+    includeInlayParameterNameHints: "all",
+    interactiveInlayHints: true
+})


Suggested change

})

});

DanielRosenwasser · 2023-08-23T23:40:13Z

@typescript-bot pack this
@typescript-bot user test tsserver
@typescript-bot test tsserver top100
@typescript-bot perf test this

typescript-bot · 2023-08-23T23:40:16Z

Heya @DanielRosenwasser, I've started to run the diff-based top-repos suite (tsserver) on this PR at 647dc07. You can monitor the build here.

typescript-bot · 2023-08-23T23:40:16Z

Heya @DanielRosenwasser, I've started to run the regular perf test suite on this PR at 647dc07. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-08-23T23:40:16Z

Heya @DanielRosenwasser, I've started to run the diff-based user code test suite (tsserver) on this PR at 647dc07. You can monitor the build here.

typescript-bot · 2023-08-23T23:40:16Z

Heya @DanielRosenwasser, I've started to run the tarball bundle task on this PR at 647dc07. You can monitor the build here.

DanielRosenwasser · 2023-08-23T23:40:19Z

@typescript-bot cherry-pick this to release-5.2 and LKG

typescript-bot · 2023-08-23T23:40:21Z

Heya @DanielRosenwasser, I've started to run the task to cherry-pick this into release-5.2 on this PR at 647dc07. You can monitor the build here.

typescript-bot · 2023-08-23T23:42:20Z

Hey @DanielRosenwasser, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/156871/artifacts?artifactName=tgz&fileId=EC7F3FA79042593271D240E9305343171AE453E67B66D470F86070A65BFA282502&fileName=/typescript-5.3.0-insiders.20230823.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@5.3.0-pr-55476-8".;

typescript-bot · 2023-08-23T23:45:53Z

Hey @DanielRosenwasser, I couldn't open a PR with the cherry-pick. (You can check the log here). You may need to squash and pick this PR into release-5.2 manually.

typescript-bot · 2023-08-24T00:10:38Z

@DanielRosenwasser
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Angular - node (v16.17.1, x64)}
_{Memory used}	_{300,272k (± 0.00%)}	_{300,276k (± 0.01%)}	_~	_300,253k	_300,306k	_{p=0.873 n=6}
_{Parse Time}	_{3.02s (± 0.18%)}	_{3.03s (± 0.13%)}	_~	_3.02s	_3.03s	_{p=0.282 n=6}
_{Bind Time}	_{0.93s (± 0.00%)}	_{0.93s (± 0.00%)}	_~	_0.93s	_0.93s	_{p=1.000 n=6}
_{Check Time}	_{9.30s (± 0.20%)}	_{9.30s (± 0.23%)}	_~	_9.28s	_9.34s	_{p=0.933 n=6}
_{Emit Time}	_{7.62s (± 0.19%)}	_{7.63s (± 0.27%)}	_~	_7.60s	_7.65s	_{p=0.623 n=6}
_{Total Time}	_{20.88s (± 0.09%)}	_{20.89s (± 0.14%)}	_~	_20.86s	_20.94s	_{p=0.511 n=6}
_{Compiler-Unions - node (v16.17.1, x64)}
_{Memory used}	_{193,893k (± 0.01%)}	_{193,878k (± 0.01%)}	_~	_193,862k	_193,903k	_{p=0.128 n=6}
_{Parse Time}	_{1.58s (± 0.26%)}	_{1.58s (± 0.26%)}	_~	_1.58s	_1.59s	_{p=1.000 n=6}
_{Bind Time}	_{0.80s (± 0.00%)}	_{0.80s (± 0.51%)}	_~	_0.79s	_0.80s	_{p=0.405 n=6}
_{Check Time}	_{9.95s (± 0.28%)}	_{9.97s (± 0.27%)}	_~	_9.92s	_9.99s	_{p=0.257 n=6}
_{Emit Time}	_{2.74s (± 0.30%)}	_{2.73s (± 0.36%)}	_~	_2.72s	_2.74s	_{p=0.498 n=6}
_{Total Time}	_{15.06s (± 0.17%)}	_{15.08s (± 0.19%)}	_~	_15.03s	_15.11s	_{p=0.258 n=6}
_{Monaco - node (v16.17.1, x64)}
_{Memory used}	_{347,150k (± 0.01%)}	_{347,153k (± 0.01%)}	_~	_347,104k	_347,173k	_{p=0.471 n=6}
_{Parse Time}	_{2.69s (± 0.33%)}	_{2.69s (± 0.28%)}	_~	_2.68s	_2.70s	_{p=0.798 n=6}
_{Bind Time}	_{0.99s (± 0.00%)}	_{0.99s (± 0.00%)}	_~	_0.99s	_0.99s	_{p=1.000 n=6}
_{Check Time}	_{7.92s (± 0.48%)}	_{7.93s (± 0.43%)}	_~	_7.89s	_7.97s	_{p=1.000 n=6}
_{Emit Time}	_{4.25s (± 0.35%)}	_{4.27s (± 0.39%)}	_{+0.02s (+ 0.43%)}	_4.25s	_4.29s	_{p=0.049 n=6}
_{Total Time}	_{15.86s (± 0.30%)}	_{15.88s (± 0.29%)}	_~	_15.83s	_15.93s	_{p=0.571 n=6}
_{TFS - node (v16.17.1, x64)}
_{Memory used}	_{301,157k (± 0.00%)}	_{301,157k (± 0.00%)}	_~	_301,142k	_301,167k	_{p=0.809 n=6}
_{Parse Time}	_{2.18s (± 0.70%)}	_{2.17s (± 0.50%)}	_~	_2.16s	_2.18s	_{p=0.666 n=6}
_{Bind Time}	_{1.11s (± 0.46%)}	_{1.11s (± 0.00%)}	_~	_1.11s	_1.11s	_{p=0.174 n=6}
_{Check Time}	_{7.25s (± 0.45%)}	_{7.25s (± 0.17%)}	_~	_7.24s	_7.27s	_{p=1.000 n=6}
_{Emit Time}	_{3.98s (± 0.43%)}	_{3.97s (± 0.26%)}	_~	_3.96s	_3.99s	_{p=0.410 n=6}
_{Total Time}	_{14.52s (± 0.21%)}	_{14.51s (± 0.10%)}	_~	_14.49s	_14.53s	_{p=1.000 n=6}
_{material-ui - node (v16.17.1, x64)}
_{Memory used}	_{479,414k (± 0.00%)}	_{479,413k (± 0.00%)}	_~	_479,395k	_479,434k	_{p=0.810 n=6}
_{Parse Time}	_{3.15s (± 0.13%)}	_{3.15s (± 0.24%)}	_~	_3.14s	_3.16s	_{p=1.000 n=6}
_{Bind Time}	_{0.91s (± 0.00%)}	_{0.91s (± 0.00%)}	_~	_0.91s	_0.91s	_{p=1.000 n=6}
_{Check Time}	_{17.79s (± 0.32%)}	_{17.81s (± 0.46%)}	_~	_17.71s	_17.91s	_{p=0.810 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{21.85s (± 0.27%)}	_{21.87s (± 0.39%)}	_~	_21.77s	_21.97s	_{p=0.873 n=6}
_{xstate - node (v16.17.1, x64)}
_{Memory used}	_{542,863k (± 0.01%)}	_{542,841k (± 0.01%)}	_~	_542,800k	_542,907k	_{p=0.378 n=6}
_{Parse Time}	_{3.70s (± 0.11%)}	_{3.70s (± 0.33%)}	_~	_3.69s	_3.72s	_{p=0.285 n=6}
_{Bind Time}	_{1.38s (± 4.42%)}	_{1.40s (± 4.83%)}	_~	_1.33s	_1.46s	_{p=0.553 n=6}
_{Check Time}	_{3.29s (± 2.84%)}	_{3.25s (± 2.70%)}	_~	_3.17s	_3.34s	_{p=0.515 n=6}
_{Emit Time}	_{0.08s (± 0.00%)}	_{0.08s (± 0.00%)}	_~	_0.08s	_0.08s	_{p=1.000 n=6}
_{Total Time}	_{8.44s (± 0.36%)}	_{8.44s (± 0.36%)}	_~	_8.40s	_8.47s	_{p=0.936 n=6}

System info unknown

Hosts

node (v16.17.1, x64)

Scenarios

Angular - node (v16.17.1, x64)
Compiler-Unions - node (v16.17.1, x64)
Monaco - node (v16.17.1, x64)
TFS - node (v16.17.1, x64)
material-ui - node (v16.17.1, x64)
xstate - node (v16.17.1, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

tsserver

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{2,493ms (± 0.15%)}	_{2,491ms (± 0.10%)}	_~	_2,488ms	_2,495ms	_{p=0.570 n=6}
_{Req 2 - geterr}	_{5,965ms (± 0.48%)}	_{5,945ms (± 0.38%)}	_~	_5,928ms	_5,988ms	_{p=0.126 n=6}
_{Req 3 - references}	_{342ms (± 0.12%)}	_{342ms (± 0.30%)}	_~	_341ms	_344ms	_{p=0.924 n=6}
_{Req 4 - navto}	_{278ms (± 0.44%)}	_{277ms (± 0.29%)}	_~	_276ms	_278ms	_{p=0.177 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{84ms (± 8.89%)}	_{84ms (± 8.17%)}	_~	_76ms	_93ms	_{p=0.935 n=6}
_{CompilerTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{2,621ms (± 0.52%)}	_{2,629ms (± 0.92%)}	_~	_2,600ms	_2,663ms	_{p=0.575 n=6}
_{Req 2 - geterr}	_{4,772ms (± 0.25%)}	_{4,764ms (± 0.16%)}	_~	_4,755ms	_4,776ms	_{p=0.229 n=6}
_{Req 3 - references}	_{350ms (± 0.29%)}	_{350ms (± 0.21%)}	_~	_349ms	_351ms	_{p=0.437 n=6}
_{Req 4 - navto}	_{270ms (± 0.39%)}	_{270ms (± 0.20%)}	_~	_269ms	_270ms	_{p=1.000 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{79ms (± 0.00%)}	_{79ms (± 0.65%)}	_~	_79ms	_80ms	_{p=0.174 n=6}
_{xstateTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{2,713ms (± 0.19%)}	_{2,717ms (± 0.06%)}	_~	_2,715ms	_2,719ms	_{p=0.170 n=6}
_{Req 2 - geterr}	_{1,948ms (± 1.75%)}	_{1,944ms (± 1.39%)}	_~	_1,901ms	_1,974ms	_{p=0.872 n=6}
_{Req 3 - references}	_{138ms (± 2.70%)}	_{134ms (± 1.46%)}	_~	_131ms	_137ms	_{p=0.218 n=6}
_{Req 4 - navto}	_{353ms (± 0.42%)}	_{353ms (± 0.23%)}	_~	_352ms	_354ms	_{p=0.508 n=6}
_{Req 5 - completionInfo count}	_{2,071 (± 0.00%)}	_{2,071 (± 0.00%)}	_~	_2,071	_2,071	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{313ms (± 1.56%)}	_{311ms (± 0.32%)}	_~	_310ms	_313ms	_{p=0.868 n=6}

System info unknown

Hosts

node (v16.17.1, x64)

Scenarios

CompilerTSServer - node (v16.17.1, x64)
Compiler-UnionsTSServer - node (v16.17.1, x64)
xstateTSServer - node (v16.17.1, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Startup

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v16.17.1, x64)}
_{Execution time}	_{155.63ms (± 0.15%)}	_{155.52ms (± 0.16%)}	_{-0.11ms (- 0.07%)}	_154.53ms	_158.24ms	_{p=0.000 n=600}
_{tsserver-startup - node (v16.17.1, x64)}
_{Execution time}	_{230.20ms (± 0.12%)}	_{230.91ms (± 0.14%)}	_{+0.71ms (+ 0.31%)}	_229.37ms	_237.31ms	_{p=0.000 n=600}
_{tsserverlibrary-startup - node (v16.17.1, x64)}
_{Execution time}	_{234.93ms (± 0.14%)}	_{236.12ms (± 0.12%)}	_{+1.19ms (+ 0.50%)}	_235.06ms	_242.41ms	_{p=0.000 n=600}
_{typescript-startup - node (v16.17.1, x64)}
_{Execution time}	_{236.02ms (± 0.19%)}	_{235.85ms (± 0.19%)}	_{-0.17ms (- 0.07%)}	_234.56ms	_251.31ms	_{p=0.000 n=600}

System info unknown

Hosts

node (v16.17.1, x64)

Scenarios

tsc-startup - node (v16.17.1, x64)
tsserver-startup - node (v16.17.1, x64)
tsserverlibrary-startup - node (v16.17.1, x64)
typescript-startup - node (v16.17.1, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

…and LKG (#55487) Co-authored-by: Maria José Solano <majosolano99@gmail.com>

…oft#55476)

Get source file from parameter node

d5d8975

typescript-bot assigned MariaSolOs Aug 23, 2023

typescript-bot added the For Milestone Bug PRs that fix a bug with a specific milestone label Aug 23, 2023

MariaSolOs requested a review from DanielRosenwasser August 23, 2023 00:25

DanielRosenwasser requested changes Aug 23, 2023

View reviewed changes

src/server/session.ts Outdated Show resolved Hide resolved

MariaSolOs added 2 commits August 22, 2023 18:00

Add Debug assertion for file

99c7ae2

Add test

52496b2

MariaSolOs marked this pull request as ready for review August 23, 2023 01:14

MariaSolOs commented Aug 23, 2023

View reviewed changes

tests/cases/fourslash/inlayHintsInteractiveMultifileFunctionCalls.ts Show resolved Hide resolved

DanielRosenwasser reviewed Aug 23, 2023

View reviewed changes

Missing semicolons make me nervous

647dc07

DanielRosenwasser approved these changes Aug 23, 2023

View reviewed changes

DanielRosenwasser merged commit 5fe88ea into microsoft:main Aug 23, 2023
19 checks passed

MariaSolOs deleted the inlay-hints-sourcefile branch August 23, 2023 23:44

MariaSolOs restored the inlay-hints-sourcefile branch August 23, 2023 23:46

DanielRosenwasser pushed a commit that referenced this pull request Aug 23, 2023

[Interactive inlay hints] Get source file from parameter node (#55476)

11b165e

DanielRosenwasser mentioned this pull request Aug 23, 2023

Cherry-pick fix for cross-file inlay hints (#55476) to release-5.2 and LKG #55487

Merged

DanielRosenwasser added a commit that referenced this pull request Aug 24, 2023

Cherry-pick fix for cross-file inlay hints (#55476) to release-5.2 …

9684ba6

…and LKG (#55487) Co-authored-by: Maria José Solano <majosolano99@gmail.com>

snovader pushed a commit to mestro-se/TypeScript that referenced this pull request Sep 23, 2023

[Interactive inlay hints] Get source file from parameter node (micros…

443123b

…oft#55476)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Interactive inlay hints] Get source file from parameter node #55476

[Interactive inlay hints] Get source file from parameter node #55476

MariaSolOs commented Aug 23, 2023

DanielRosenwasser left a comment

MariaSolOs commented Aug 23, 2023

DanielRosenwasser Aug 23, 2023

DanielRosenwasser Aug 23, 2023

DanielRosenwasser commented Aug 23, 2023

typescript-bot commented Aug 23, 2023 •

edited

Loading

typescript-bot commented Aug 23, 2023 •

edited

Loading

typescript-bot commented Aug 23, 2023 •

edited

Loading

typescript-bot commented Aug 23, 2023 •

edited

Loading

DanielRosenwasser commented Aug 23, 2023

typescript-bot commented Aug 23, 2023 •

edited

Loading

typescript-bot commented Aug 23, 2023 •

edited

Loading

typescript-bot commented Aug 23, 2023

typescript-bot commented Aug 24, 2023

Compiler

tsserver

Startup

[Interactive inlay hints] Get source file from parameter node #55476

[Interactive inlay hints] Get source file from parameter node #55476

Conversation

MariaSolOs commented Aug 23, 2023

DanielRosenwasser left a comment

Choose a reason for hiding this comment

MariaSolOs commented Aug 23, 2023

DanielRosenwasser Aug 23, 2023

Choose a reason for hiding this comment

DanielRosenwasser Aug 23, 2023

Choose a reason for hiding this comment

DanielRosenwasser commented Aug 23, 2023

typescript-bot commented Aug 23, 2023 • edited Loading

typescript-bot commented Aug 23, 2023 • edited Loading

typescript-bot commented Aug 23, 2023 • edited Loading

typescript-bot commented Aug 23, 2023 • edited Loading

DanielRosenwasser commented Aug 23, 2023

typescript-bot commented Aug 23, 2023 • edited Loading

typescript-bot commented Aug 23, 2023 • edited Loading

typescript-bot commented Aug 23, 2023

typescript-bot commented Aug 24, 2023

Compiler

tsserver

Startup

typescript-bot commented Aug 23, 2023 •

edited

Loading

typescript-bot commented Aug 23, 2023 •

edited

Loading

typescript-bot commented Aug 23, 2023 •

edited

Loading

typescript-bot commented Aug 23, 2023 •

edited

Loading

typescript-bot commented Aug 23, 2023 •

edited

Loading

typescript-bot commented Aug 23, 2023 •

edited

Loading