Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick info for element access to mapped object #58939

Closed
wants to merge 4 commits into from

Conversation

KermanX
Copy link

@KermanX KermanX commented Jun 20, 2024

Fixes #58908.

This PR adds the quick info for element accessing to mapped types. For example, the red text below:
image

@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Jun 20, 2024
@typescript-bot
Copy link
Collaborator

The TypeScript team hasn't accepted the linked issue #58908. If you can get it accepted, this PR will have a better chance of being reviewed.

@KermanX
Copy link
Author

KermanX commented Jun 20, 2024

@microsoft-github-policy-service agree

@KermanX KermanX changed the title fix: quick info for element access to mapped object Quick info for element access to mapped object Jun 20, 2024
@sandersn sandersn self-assigned this Jun 28, 2024
@sandersn sandersn self-requested a review June 28, 2024 13:00
@sandersn
Copy link
Member

It's not worth it for us to review PRs before the bug has an accepted design for its fix, because the final design will certainly change the implementation. In this case, the PR produces number which was the very first proposal, but discussion has produced a number of better suggestions.

I'd recommend closing this PR until there's an accepted wording for the quick info, and then updating+reopening.

@KermanX KermanX closed this Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

use [""] in object will lose ts check
3 participants