Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Signature monomorphic #59192

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dragomirtitian
Copy link
Contributor

Part of #58928 - Only make signatures monomorphic.

@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Jul 8, 2024
@jakebailey
Copy link
Member

@typescript-bot perf test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jul 8, 2024

Starting jobs; this comment will be updated as builds start and complete.

Command Status Results
perf test this ✅ Started 👀 Results

@typescript-bot
Copy link
Collaborator

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr
Metric baseline pr Delta Best Worst p-value
Compiler-Unions - node (v18.15.0, x64)
Errors 30 30 ~ ~ ~ p=1.000 n=6
Symbols 62,153 62,153 ~ ~ ~ p=1.000 n=6
Types 50,242 50,242 ~ ~ ~ p=1.000 n=6
Memory used 193,434k (± 0.94%) 193,349k (± 0.94%) ~ 192,087k 195,686k p=0.298 n=6
Parse Time 1.30s (± 0.40%) 1.30s (± 0.63%) ~ 1.29s 1.31s p=0.929 n=6
Bind Time 0.71s 0.71s ~ ~ ~ p=1.000 n=6
Check Time 9.46s (± 0.34%) 9.41s (± 0.27%) -0.05s (- 0.56%) 9.39s 9.45s p=0.019 n=6
Emit Time 2.75s (± 0.63%) 2.73s (± 0.45%) ~ 2.72s 2.75s p=0.188 n=6
Total Time 14.22s (± 0.25%) 14.16s (± 0.14%) -0.06s (- 0.45%) 14.13s 14.18s p=0.013 n=6
angular-1 - node (v18.15.0, x64)
Errors 5 5 ~ ~ ~ p=1.000 n=6
Symbols 944,114 944,114 ~ ~ ~ p=1.000 n=6
Types 407,050 407,050 ~ ~ ~ p=1.000 n=6
Memory used 1,218,377k (± 0.00%) 1,217,450k (± 0.00%) -927k (- 0.08%) 1,217,400k 1,217,506k p=0.005 n=6
Parse Time 7.99s (± 0.82%) 7.98s (± 0.30%) ~ 7.95s 8.01s p=0.935 n=6
Bind Time 2.23s (± 0.55%) 2.24s (± 0.77%) ~ 2.22s 2.26s p=0.157 n=6
Check Time 35.90s (± 0.44%) 35.28s (± 0.44%) -0.62s (- 1.72%) 35.14s 35.53s p=0.005 n=6
Emit Time 16.18s (± 0.29%) 16.14s (± 0.88%) ~ 15.93s 16.35s p=0.296 n=6
Total Time 62.29s (± 0.26%) 61.63s (± 0.23%) -0.66s (- 1.06%) 61.48s 61.88s p=0.005 n=6
mui-docs - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 2,130,343 2,130,343 ~ ~ ~ p=1.000 n=6
Types 927,684 927,684 ~ ~ ~ p=1.000 n=6
Memory used 2,107,262k (± 0.00%) 2,106,585k (± 0.00%) -677k (- 0.03%) 2,106,545k 2,106,627k p=0.005 n=6
Parse Time 6.62s (± 0.32%) 6.62s (± 0.35%) ~ 6.58s 6.64s p=0.623 n=6
Bind Time 2.33s (± 0.42%) 2.32s (± 0.35%) ~ 2.31s 2.33s p=0.181 n=6
Check Time 70.79s (± 0.45%) 70.48s (± 0.31%) ~ 70.17s 70.77s p=0.065 n=6
Emit Time 0.13s (± 3.87%) 0.14s (± 4.05%) ~ 0.13s 0.14s p=0.640 n=6
Total Time 79.87s (± 0.39%) 79.56s (± 0.29%) -0.31s (- 0.39%) 79.27s 79.85s p=0.044 n=6
self-build-src - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 1,225,588 1,226,038 +450 (+ 0.04%) ~ ~ p=0.001 n=6
Types 261,474 261,486 +12 (+ 0.00%) ~ ~ p=0.001 n=6
Memory used 2,341,817k (± 0.03%) 2,341,437k (± 0.07%) ~ 2,339,612k 2,343,777k p=0.575 n=6
Parse Time 6.02s (± 0.79%) 6.05s (± 0.91%) ~ 5.99s 6.13s p=0.575 n=6
Bind Time 2.25s (± 0.46%) 2.26s (± 0.67%) ~ 2.24s 2.28s p=0.517 n=6
Check Time 40.37s (± 0.81%) 39.69s (± 0.86%) -0.68s (- 1.68%) 39.27s 40.24s p=0.013 n=6
Emit Time 3.05s (± 2.91%) 3.20s (± 1.42%) 🔻+0.15s (+ 4.80%) 3.14s 3.27s p=0.013 n=6
Total Time 51.73s (± 0.86%) 51.22s (± 0.68%) ~ 50.85s 51.76s p=0.066 n=6
self-build-src-public-api - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 1,225,588 1,226,038 +450 (+ 0.04%) ~ ~ p=0.001 n=6
Types 261,474 261,486 +12 (+ 0.00%) ~ ~ p=0.001 n=6
Memory used 2,415,051k (± 0.03%) 2,417,086k (± 0.18%) ~ 2,413,763k 2,422,674k p=0.936 n=6
Parse Time 5.20s (± 1.08%) 5.19s (± 0.90%) ~ 5.13s 5.26s p=0.748 n=6
Bind Time 1.70s (± 0.61%) 1.69s (± 0.48%) ~ 1.68s 1.70s p=0.112 n=6
Check Time 34.60s (± 0.30%) 34.05s (± 0.33%) -0.54s (- 1.57%) 33.89s 34.17s p=0.005 n=6
Emit Time 2.69s (± 5.31%) 2.71s (± 2.43%) ~ 2.63s 2.82s p=0.128 n=6
Total Time 44.18s (± 0.48%) 43.66s (± 0.32%) -0.52s (- 1.17%) 43.48s 43.81s p=0.005 n=6
self-compiler - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 258,188 258,235 +47 (+ 0.02%) ~ ~ p=0.001 n=6
Types 104,737 104,744 +7 (+ 0.01%) ~ ~ p=0.001 n=6
Memory used 427,463k (± 0.01%) 427,322k (± 0.01%) -141k (- 0.03%) 427,270k 427,373k p=0.005 n=6
Parse Time 2.71s (± 0.71%) 2.70s (± 1.86%) ~ 2.60s 2.75s p=0.935 n=6
Bind Time 1.10s (± 1.24%) 1.11s (± 2.70%) ~ 1.09s 1.17s p=0.370 n=6
Check Time 15.14s (± 0.33%) 14.88s (± 0.36%) -0.26s (- 1.72%) 14.81s 14.97s p=0.005 n=6
Emit Time 1.07s (± 1.84%) 1.06s (± 1.73%) ~ 1.04s 1.09s p=0.564 n=6
Total Time 20.01s (± 0.35%) 19.74s (± 0.30%) -0.27s (- 1.35%) 19.67s 19.82s p=0.005 n=6
ts-pre-modules - node (v18.15.0, x64)
Errors 35 35 ~ ~ ~ p=1.000 n=6
Symbols 224,565 224,565 ~ ~ ~ p=1.000 n=6
Types 93,734 93,734 ~ ~ ~ p=1.000 n=6
Memory used 369,561k (± 0.04%) 369,300k (± 0.02%) -261k (- 0.07%) 369,181k 369,373k p=0.005 n=6
Parse Time 2.31s (± 0.45%) 2.30s (± 0.93%) ~ 2.26s 2.32s p=0.211 n=6
Bind Time 1.32s (± 0.57%) 1.32s (± 1.48%) ~ 1.29s 1.35s p=0.672 n=6
Check Time 13.14s (± 0.19%) 12.87s (± 0.25%) -0.27s (- 2.04%) 12.81s 12.90s p=0.005 n=6
Emit Time 0.00s 0.00s ~ ~ ~ p=1.000 n=6
Total Time 16.77s (± 0.13%) 16.49s (± 0.27%) -0.29s (- 1.72%) 16.44s 16.54s p=0.005 n=6
vscode - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 2,884,910 2,884,910 ~ ~ ~ p=1.000 n=6
Types 976,550 976,550 ~ ~ ~ p=1.000 n=6
Memory used 3,047,989k (± 0.00%) 3,046,090k (± 0.00%) -1,899k (- 0.06%) 3,046,056k 3,046,192k p=0.005 n=6
Parse Time 16.88s (± 0.16%) 16.93s (± 0.09%) +0.05s (+ 0.31%) 16.90s 16.94s p=0.010 n=6
Bind Time 5.12s (± 2.01%) 5.13s (± 1.81%) ~ 5.06s 5.31s p=0.872 n=6
Check Time 91.71s (± 2.83%) 89.22s (± 2.12%) ~ 87.92s 92.83s p=0.066 n=6
Emit Time 26.89s (± 9.23%) 28.20s (± 6.75%) ~ 24.59s 29.44s p=0.377 n=6
Total Time 140.60s (± 0.14%) 139.47s (± 0.21%) -1.13s (- 0.80%) 139.16s 139.98s p=0.005 n=6
webpack - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 267,117 267,117 ~ ~ ~ p=1.000 n=6
Types 108,775 108,775 ~ ~ ~ p=1.000 n=6
Memory used 411,617k (± 0.02%) 411,235k (± 0.01%) -382k (- 0.09%) 411,187k 411,323k p=0.005 n=6
Parse Time 4.70s (± 0.59%) 4.69s (± 0.29%) ~ 4.66s 4.70s p=0.460 n=6
Bind Time 2.07s (± 0.56%) 2.08s (± 0.80%) ~ 2.06s 2.10s p=0.222 n=6
Check Time 20.77s (± 0.44%) 20.44s (± 0.39%) -0.33s (- 1.57%) 20.35s 20.55s p=0.005 n=6
Emit Time 0.00s 0.00s ~ ~ ~ p=1.000 n=6
Total Time 27.54s (± 0.44%) 27.21s (± 0.32%) -0.33s (- 1.19%) 27.12s 27.34s p=0.005 n=6
xstate-main - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 525,251 525,251 ~ ~ ~ p=1.000 n=6
Types 178,574 178,574 ~ ~ ~ p=1.000 n=6
Memory used 462,616k (± 0.05%) 462,641k (± 0.07%) ~ 462,210k 462,979k p=0.936 n=6
Parse Time 3.93s (± 0.41%) 3.94s (± 0.71%) ~ 3.91s 3.97s p=0.870 n=6
Bind Time 1.45s (± 0.68%) 1.45s (± 0.62%) ~ 1.44s 1.46s p=0.931 n=6
Check Time 22.17s (± 0.46%) 22.03s (± 0.55%) ~ 21.91s 22.20s p=0.093 n=6
Emit Time 0.00s 0.00s (±154.76%) ~ 0.00s 0.01s p=0.174 n=6
Total Time 27.55s (± 0.35%) 27.42s (± 0.41%) ~ 27.31s 27.57s p=0.127 n=6
System info unknown
Hosts
  • node (v18.15.0, x64)
Scenarios
  • Compiler-Unions - node (v18.15.0, x64)
  • angular-1 - node (v18.15.0, x64)
  • mui-docs - node (v18.15.0, x64)
  • self-build-src - node (v18.15.0, x64)
  • self-build-src-public-api - node (v18.15.0, x64)
  • self-compiler - node (v18.15.0, x64)
  • ts-pre-modules - node (v18.15.0, x64)
  • vscode - node (v18.15.0, x64)
  • webpack - node (v18.15.0, x64)
  • xstate-main - node (v18.15.0, x64)
Benchmark Name Iterations
Current pr 6
Baseline baseline 6

tsserver

Comparison Report - baseline..pr
Metric baseline pr Delta Best Worst p-value
Compiler-UnionsTSServer - node (v18.15.0, x64)
Req 1 - updateOpen 2,915ms (± 9.64%) 2,880ms (± 9.19%) ~ 2,743ms 3,419ms p=0.748 n=6
Req 2 - geterr 6,950ms (± 9.50%) 7,108ms (± 6.97%) ~ 6,097ms 7,352ms p=0.471 n=6
Req 3 - references 369ms (±10.44%) 371ms (±10.46%) ~ 321ms 402ms p=0.683 n=6
Req 4 - navto 340ms (± 0.55%) 329ms (± 7.60%) ~ 279ms 342ms p=0.567 n=6
Req 5 - completionInfo count 1,357 1,357 ~ ~ ~ p=1.000 n=6
Req 5 - completionInfo 131ms (± 0.39%) 132ms (± 2.51%) ~ 130ms 139ms p=0.928 n=6
CompilerTSServer - node (v18.15.0, x64)
Req 1 - updateOpen 3,562ms (± 0.57%) 3,598ms (± 1.26%) ~ 3,548ms 3,672ms p=0.173 n=6
Req 2 - geterr 5,551ms (± 0.77%) 5,446ms (± 0.72%) -105ms (- 1.88%) 5,399ms 5,510ms p=0.008 n=6
Req 3 - references 413ms (± 0.52%) 413ms (± 0.18%) ~ 412ms 414ms p=0.397 n=6
Req 4 - navto 334ms (± 0.62%) 336ms (± 0.56%) ~ 334ms 339ms p=0.210 n=6
Req 5 - completionInfo count 1,519 1,519 ~ ~ ~ p=1.000 n=6
Req 5 - completionInfo 109ms (± 2.95%) 108ms (± 2.61%) ~ 102ms 109ms p=0.090 n=6
xstate-main-1-tsserver - node (v18.15.0, x64)
Req 1 - updateOpen 5,187ms (± 0.66%) 5,195ms (± 0.38%) ~ 5,166ms 5,212ms p=0.936 n=6
Req 2 - geterr 1,124ms (± 1.19%) 1,127ms (± 1.52%) ~ 1,100ms 1,147ms p=0.689 n=6
Req 3 - references 76ms (± 3.67%) 76ms (± 3.15%) ~ 75ms 81ms p=1.000 n=6
Req 4 - navto 457ms (± 0.14%) 457ms (± 0.51%) ~ 456ms 462ms p=0.485 n=6
Req 5 - completionInfo count 3,413 3,413 ~ ~ ~ p=1.000 n=6
Req 5 - completionInfo 833ms (± 1.86%) 827ms (± 1.52%) ~ 809ms 843ms p=0.689 n=6
System info unknown
Hosts
  • node (v18.15.0, x64)
Scenarios
  • CompilerTSServer - node (v18.15.0, x64)
  • Compiler-UnionsTSServer - node (v18.15.0, x64)
  • xstate-main-1-tsserver - node (v18.15.0, x64)
Benchmark Name Iterations
Current pr 6
Baseline baseline 6

startup

Comparison Report - baseline..pr
Metric baseline pr Delta Best Worst p-value
tsc-startup - node (v18.15.0, x64)
Execution time 187.57ms (± 0.17%) 187.69ms (± 0.20%) +0.12ms (+ 0.06%) 185.91ms 193.38ms p=0.006 n=600
tsserver-startup - node (v18.15.0, x64)
Execution time 230.74ms (± 0.14%) 231.09ms (± 0.15%) +0.36ms (+ 0.16%) 229.56ms 238.01ms p=0.000 n=600
tsserverlibrary-startup - node (v18.15.0, x64)
Execution time 226.17ms (± 0.14%) 226.34ms (± 0.15%) +0.17ms (+ 0.08%) 224.78ms 230.61ms p=0.000 n=600
typescript-startup - node (v18.15.0, x64)
Execution time 334.89ms (± 0.30%) 335.10ms (± 0.31%) +0.21ms (+ 0.06%) 326.96ms 343.11ms p=0.000 n=600
System info unknown
Hosts
  • node (v18.15.0, x64)
Scenarios
  • tsc-startup - node (v18.15.0, x64)
  • tsserver-startup - node (v18.15.0, x64)
  • tsserverlibrary-startup - node (v18.15.0, x64)
  • typescript-startup - node (v18.15.0, x64)
Benchmark Name Iterations
Current pr 6
Baseline baseline 6

Developer Information:

Download Benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants