Skip to content

Commit

Permalink
Replace x64 check installer with x64compatible
Browse files Browse the repository at this point in the history
PR #1815 updated the installer dependency version, which seems to have caused the installer to
enforce the AllowedArchitectures=x64 check (which has been there for years). We've received
complaints from users that the latest release refuses to install on their ARM machines, but previous
versions did and worked fine with the default x86/64 emulation.

The latest version of Innosetup adds x64compatible option for the AllowedArchitectures and
ArchitecturesInstallIn64BitMode to address the case of x64 emulation on ARM.
  • Loading branch information
tyrielv committed Dec 12, 2024
1 parent 1d5c172 commit da1637a
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion GVFS/GVFS.Installers/GVFS.Installers.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
</ItemDefinitionGroup>

<ItemGroup>
<PackageReference Include="Tools.InnoSetup" Version="6.2.1" />
<PackageReference Include="Tools.InnoSetup" Version="6.3.1" />
<PackageReference Include="GitForWindows.GVFS.Installer" Version="$(GitPackageVersion)" />
<PackageReference Include="GitForWindows.GVFS.Portable" Version="$(GitPackageVersion)" />
<PackageReference Include="MicroBuild.Core" Version="0.2.0" ExcludeAssets="none" />
Expand Down
4 changes: 2 additions & 2 deletions GVFS/GVFS.Installers/Setup.iss
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,8 @@ MinVersion=10.0.14374
DisableDirPage=yes
DisableReadyPage=yes
SetupIconFile="{#LayoutDir}\GitVirtualFileSystem.ico"
ArchitecturesInstallIn64BitMode=x64
ArchitecturesAllowed=x64
ArchitecturesInstallIn64BitMode=x64compatible
ArchitecturesAllowed=x64compatible
WizardImageStretch=no
WindowResizable=no
CloseApplications=yes
Expand Down

0 comments on commit da1637a

Please sign in to comment.