-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
modified ProfileExpressionEvaluator #395
base: main
Are you sure you want to change the base?
modified ProfileExpressionEvaluator #395
Conversation
@shobha-05 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
@@ -104,10 +105,17 @@ public class ProfileExpressionEvaluator : IExpressionEvaluator | |||
@"\{([a-z0-9_-]+)\.(TotalDays|TotalHours|TotalMilliseconds|TotalMinutes|TotalSeconds)\}", | |||
RegexOptions.Compiled | RegexOptions.IgnoreCase); | |||
|
|||
// e.g. | |||
// {Isarm} | |||
private static readonly Regex Isarmexpression = new Regex( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's not do IsARM. do {platform}==linux-arm64 | {platform}==win-arm64 instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We already have {platform} supported to do this
Added new feature in ProfileExpressionEvaluator "IsArm" which will return "true" if the machine is arm otherwise it will return "false".