Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CompilerInstallation fix: Remove existing alternatives for cpp #396

Merged
merged 3 commits into from
Nov 8, 2024
+5 −3
Merged

CompilerInstallation fix: Remove existing alternatives for cpp #396

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e7c1fc5
Added line to remove existing alternatives for cpp.
Nov 8, 2024
f34a0b0
Fixing CompilerInstallation test.
Nov 8, 2024
f07ba20
Removing existing duplicate command.
Nov 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/VirtualClient/VirtualClient.Dependencies/CompilerInstallation.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,6 +276,9 @@ private async Task SetGccPriorityAsync(string gccVersion, EventContext telemetry

await this.ExecuteCommandAsync("update-alternatives", updateAlternativeArgument, Environment.CurrentDirectory, telemetryContext, cancellationToken);

// Remove all existing alternatives for cpp before the subsequent "update-alternatives" of cpp
await this.ExecuteCommandAsync("update-alternatives", "--remove-all cpp", Environment.CurrentDirectory, telemetryContext, cancellationToken);

// For some update path, the cpp can't be update-alternative by a gcc, so needs a separate call.
string updateAlternativeArgumentCpp = $"--install /usr/bin/cpp cpp /usr/bin/cpp-{gccVersion} {gccVersion}0";

Expand Down
Loading