-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync from dev #1683
Merged
Sync from dev #1683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor launchExperience to add retry policy when sync templates
- some prettier format - added svgBase64 &, iconBase64
not working on small height screens Also adjust alignment of the splashImage to not have too much black space between splash and scroll
…/prupipho/WebTemplateStudio into fixHomeSplashOnSmallHeightScreen
change right margin in stylesheet to keep splash image on small screen
- remove all unnecessary items from client solution
- TODO: create IconComponent - TODO: update mock (mockImages rather than the real ones?)
Upgrade reactscripts and fix typescript version
Remove unused packages
- showing image for features/services from templates in ServicesPage - remove unneeded svg and code to get those - TODO: Missing still to show right image from rightsidebar
…agesFromExtension
- small style - empty image
remove Preview flag from ASP.NET
Try this feature of accepting commit suggestion see how this works :) Co-authored-by: sibille <sibille@users.noreply.github.com>
oops Co-authored-by: sibille <sibille@users.noreply.github.com>
code review update Co-authored-by: sibille <sibille@users.noreply.github.com>
Fix links
added image with ASP.NET
1637 update documentation for release 0.5
…yChanges tiny accessibility amends
…tend/src/components/navbar/NavBar_postaction.js to templates/Web/_composition/ReactJS/Page.React.AddNavigate/frontend/src/components/NavBar/ NavBar_postaction.js Rename folder to case sensitive NavBar
…frontend/src/components/navbar/NavBar_postaction.js to templates/Web/_composition/ReactJS/Page.React.AddNavigateHome/frontend/src/components/NavBar/NavBar_postaction.js
Rename templates/Web/_composition/ReactJS/Page.React.AddNavigate/fron…
sibille
requested review from
dgomezc,
jcoc611-microsoft,
mvegaca and
piotrmark
as code owners
November 17, 2020 18:03
prupipho
approved these changes
Nov 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.