UITextField setText: should move caret position of underlying TextBox to end. #502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to end. Ensures caret position is correct if we programmatically gain focus (becomeFirstResponder).
| // Ensure caret at end of field in case we programmatically | ||
| // gain focus (becomeFirstResponder) after the text is set: | ||
| _textBox.selectionStart = [_text length]; | ||
| _textBox.selectionLength = 0; |
There was a problem hiding this comment.
do we want the same behavior for _passwordBox? #Resolved
There was a problem hiding this comment.
PasswordBox doesn't have the SelectionStart/Length properties. However it already implements the right functionality automatically. (I did the basic test which is to programmatically set the text then programmatically gain focus with a secureMode UITextField - the caret just appears at the end)
There was a problem hiding this comment.
|
@yiyang-msft is added to the review. #Closed |
|
|
|
|
|
Thanks for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures caret position is correct if we programmatically gain focus (becomeFirstResponder).
I'm in a situation where I have certain elements e.g. tableviewcells which, when tapped, programmatically set focus on a text field in the element (so that it's easier to bring the keyboard up without having to touch on exactly the bounds of the text field). There could also be situations where e.g. actual touches on a UITextField are blocked by another transparent UIView covering the field - with actual beginning editing of the covered UITextField handled by |becomeFirstResponder|.
This change ensures that in the above scenarios the caret is not at the beginning of the textfield's text.