Remove artifical limitation on 5D tensors for GPU #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smk2007
approved these changes
Jul 13, 2020
smk2007
reviewed
Jul 13, 2020
| @@ -293,13 +293,6 @@ HRESULT CheckIfModelAndConfigurationsAreSupported(LearningModel& model, const st | |||
| else if (inputFeature.Kind() == LearningModelFeatureKind::Tensor) | |||
| { | |||
| auto tensorFeatureDescriptor = inputFeature.try_as<TensorFeatureDescriptor>(); | |||
| if (tensorFeatureDescriptor.Shape().Size() > 4 && deviceType != DeviceType::CPU) | |||
There was a problem hiding this comment.
should you leave this check and update the check and message to allow up to 5d tensors and not 6?
There was a problem hiding this comment.
I'm adding 6D, 7D, 8D in just a few weeks. Please don't put artificial limitations in a tool, when the API should check it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes this bug: #324
WinMLRunner rejects 5D tensors, with the message "Input feature input shape is too large. GPU path only accepts tensor dimensions <= 4 : 5", even though DirectML supports 5D tensors (and will likely support more than that too).
This will allow the correct error message to flow through DirectML to WinMLRunner.