Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added azure-pipelines/build.yml #150

Merged
merged 6 commits into from
Feb 15, 2024
Merged

Conversation

jstedfast
Copy link
Member

Description of Change

Migrated from Classic Azure Pipelines to 1ES template

Bugs Fixed

  • Provide links to bugs here

API Changes

N/A

Behavioral Changes

N/A

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard

Migrated from Classic Azure Pipelines to 1ES template
Comment on lines 1 to 5
# This Yaml Document has been converted by ESAI Yaml Pipeline Conversion Tool.
# Please make sure to check all the converted content, it is your team's responsibility to make sure that the pipeline is still valid and functions as expected.
# This pipeline will be extended to the MicroBuild template
# The Task 'NuGetCommand@2' has been converted to an output named 'NuGet push to VS feed' in the templateContext section.
# The Task 'NuGetCommand@2' has been converted to an output named 'NuGet push to NuGet.org' in the templateContext section.
Copy link
Member

@mgoertz-msft mgoertz-msft Feb 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we delete this now? #Closed

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should remove it before merging, yes

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Comment on lines 1 to 5
# This Yaml Document has been converted by ESAI Yaml Pipeline Conversion Tool.
# Please make sure to check all the converted content, it is your team's responsibility to make sure that the pipeline is still valid and functions as expected.
# This pipeline will be extended to the MicroBuild template
# The Task 'NuGetCommand@2' has been converted to an output named 'NuGet push to VS feed' in the templateContext section.
# The Task 'NuGetCommand@2' has been converted to an output named 'NuGet push to NuGet.org' in the templateContext section.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

displayName: 'NuGet push to VS feed'
condition: and(succeeded(), eq(variables['Build.OfficialRelease'], 'true'))
packageParentPath: '$(Build.ArtifactStagingDirectory)'
searchPatternPush: src/Microsoft.Xaml.Behaviors/bin/Release/Microsoft.Xaml.Behaviors.Wpf.*.nupkg;!src/Microsoft.Xaml.Behaviors/bin/Release/Microsoft.Xaml.Behaviors.Wpf.*.symbols.nupkg
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had numerous pipeline failures in NuGet push until I made following changes
• Replace searchPatternPush with packagesToPush
• Replace feedPublish with publishVstsFeed
• Narrow packageParentPath to $(...)\package subfolder to avoid picking D:\a_work\1\a\MicroBuild\Verify\in\package.

@jstedfast jstedfast merged commit 90fbd01 into master Feb 15, 2024
2 checks passed
@jstedfast jstedfast deleted the dev/jestedfa/1es-migration branch February 15, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants