Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows HC] More actions menu icon is not visible when selected #4616

Closed
lisli1 opened this issue Aug 25, 2021 · 9 comments
Closed

[Windows HC] More actions menu icon is not visible when selected #4616

lisli1 opened this issue Aug 25, 2021 · 9 comments
Labels
bug Something isn't working status: resolved This issue has been merged into main and deployed to canary.

Comments

@lisli1
Copy link
Contributor

lisli1 commented Aug 25, 2021

Describe the bug

  1. When the "more actions" menu icon is selected, the icon is no longer visible.
  2. Similarly, when the menu items are hovered, there does not seem to be sufficient contrast.
  • In Windows High Contrast 1, (1) is present.
  • In Windows High Contrast 2, (1) is present.
  • In Windows High Contrast Black, (1) and (2) are present. For (2), the text of the menu items has insufficient contrast.
  • In Windows High Contrast White, (2) is present. The icons of the menu items have insufficient contrast.

To Reproduce
Steps to reproduce the behavior:

  1. Turn on Windows HC mode (not from within AI-Web)
  2. Run automated checks
  3. Open the cards view
  4. Select the "more actions" menu on the footer of a card
  5. Hover the resulting menu items

CodePen repro example

Expected behavior

In all Windows high contrast themes, the (1) menu icon and (2) menu items should still be visible and have sufficient contrast when selected/hovered.

Screenshots

  • AI Web high contrast (not Windows high contrast) shows menu icon and menu items visible, with sufficient contrast:
    image

  • Windows High Contrast 1 shows menu icon not visible:
    image

  • Windows High Contrast 2 shows menu icon not visible:
    image

  • Windows High Contrast Black shows menu icon not visible and text of menu items with insufficient contrast:
    image

  • Windows High Contrast White shows icon of menu items with insufficient contrast:
    image

Context (please complete the following information)

Are you willing to submit a PR?

Yes

Did you search for similar existing issues?

Yes

Additional context

Similar to #4326, but this is happening when the menu is selected and menu items are hovered. The icon and menu items are visible when not in the selected/hover states.

@lisli1 lisli1 added the bug Something isn't working label Aug 25, 2021
@ghost ghost added the status: new This issue is new and requires triage by DRI. label Aug 25, 2021
@ghost ghost assigned dbjorge Aug 25, 2021
@dbjorge dbjorge added the status: ready for triage This issue is ready to be triaged by the Accessibility Insights team. label Aug 30, 2021
@ghost ghost assigned ferBonnin Aug 30, 2021
@ghost
Copy link

ghost commented Aug 30, 2021

This issue has been marked as ready for team triage; we will triage it in our weekly review and update the issue. Thank you for contributing to Accessibility Insights!

@ghost ghost removed the status: new This issue is new and requires triage by DRI. label Aug 30, 2021
@ferBonnin
Copy link
Contributor

triaged with @peterdur

@ferBonnin ferBonnin added the status: ready for work This issue is ready to be worked on. label Aug 30, 2021
@ghost ghost removed the status: ready for triage This issue is ready to be triaged by the Accessibility Insights team. label Aug 30, 2021
@jlperkins jlperkins self-assigned this Nov 1, 2021
@jlperkins
Copy link
Contributor

Investigated from a machine running Windows 11. There are new high contrast modes available in Windows 11, entitled Aquatic, Desert, Dusk, and Night Sky. The Windows 10 high contrast modes (High Contrast 1, HC2, HC Black, HC White) are no longer available settings in Windows 11. Each new Windows 11 high contrast theme has color contrast issues, as listed and shown below. The cursor is not visible in the screenshots, but each screenshot was taken with the mouse hovering over the first menu item ("File issue").

aquatic
Aquatic high contrast theme, with insufficient contrast in the more actions menu icon and the menu items' text when highlighted.

desert
Desert high contrast theme, with insufficient contrast in the menu items' text when highlighted. The menu icon here has sufficient contrast.

dusk
Dusk high contrast theme, with insufficient contrast in the more actions menu icon and the menu items' text when highlighted.

night sky
Night Sky high contrast theme, with insufficient contrast in the more actions menu icon and the menu items' text when highlighted.

A dev who attempts to work on the original issue here should ideally still be running Windows 10. There does not appear to be a way to properly apply Windows 10's contrast modes (High Contrast 1, 2, Black, and White) in Windows 11. Workarounds exist, but do not successfully apply the Windows 10 modes to browsers... instead, you get a mix of modes from Windows 10 and 11 applied to different apps on the screen. See image below, where this mix of modes is shown.
image
Image of screen after High Contrast 1 (from Windows 10) was manually enabled on Windows 11. Teams looks like High Contrast 1, but notepad and edge look like Aquatic (a new Windows 11 theme).

Because of this, this bug is best addressed by a dev who has not yet updated their machine to Windows 11.

@jlperkins jlperkins removed their assignment Nov 2, 2021
@katydecorah
Copy link
Contributor

Providing an update on this bug as result of the FluentUI v8 upgrade (#5244) as the state of this bug has shifted slightly.

Current state of web

The high contrast issue on the kebab menu was almost completely resolved for web, the Desert theme is the only Windows 11 high contrast theme that needs to be addressed.

Theme Original bug report Current (post-FluentUI v8 release)
Aquatic Aquatic high contrast theme, with insufficient contrast in the more actions menu icon and the menu items' text when highlighted. Aquatic high contrast theme with sufficient contrast
Desert Desert high contrast theme, with insufficient contrast in the menu items' text when highlighted. The menu icon here has sufficient contrast. Desert high contrast theme with the hover showing still low contrast
Dusk Dusk high contrast theme, with insufficient contrast in the more actions menu icon and the menu items' text when highlighted. Dusk high contrast theme with sufficient contrast
Night sky Night Sky high contrast theme, with insufficient contrast in the more actions menu icon and the menu items' text when highlighted. Night sky high contrast theme with sufficient contrast

Current state of unified

The menu items hover state in the kebab menu for unified all have low contrast and need to be addressed, except for Desert where the text has an acceptable ratio but the icon does not.

Theme Current (post-FluentUI v8 release)
Aquatic Insufficient contrast ratio on hovered kebab menu item in Aquatic theme
Desert Insufficient contrast ratio on hovered kebab menu item in desert theme
Dusk Insufficient contrast ratio on hovered kebab menu item in dusk theme
Night sky Insufficient contrast ratio on hovered kebab menu item in night sky theme

Summary of bug fix requirements

To close this out, the following will need to be addressed:

  • The contrast ratio of the hover state of kebab menu items in Web using the Desert high contrast theme.
  • The contrast ratio of the hover state of kebab menu items in Unified (against all high contrast themes).
  • If possible, validate hover state of kebab menu and items in Web and Unified with Windows 10 themes as recommended in [Windows HC] More actions menu icon is not visible when selected #4616 (comment)

@katydecorah katydecorah self-assigned this Jun 1, 2022
@katydecorah katydecorah added status: resolved This issue has been merged into main and deployed to canary. and removed status: ready for work This issue is ready to be worked on. labels Jun 3, 2022
@ferBonnin ferBonnin added the status: needs author feedback This issue requires additional information from the issue author. label Jun 9, 2022
@ghost
Copy link

ghost commented Jun 9, 2022

The team requires additional author feedback; please review their replies and update this issue accordingly. Thank you for contributing to Accessibility Insights!

@lisli1
Copy link
Contributor Author

lisli1 commented Jun 10, 2022

Verified issue is fixed in Web Canary Version 2022.6.8.1622 with Windows 11 Aquatic, Desert, Dusk, and Night Sky contrast themes (no longer have access to a Windows 10 device to test).

Also verified issue is fixed in Unified Canary Version 2022.609.3 with Windows 11 Aquatic, Desert, Dusk, and Night Sky contrast themes.

Noticed in Unified Canary Version 2022.609.3 with Windows 11 Desert contrast theme that the "more actions" menu button is not visible until it is hovered. (see gif below) However, this is not the same as the original issue, which was indeed fixed, so I'm fine to close this issue and open a new one for this if others can repro. @ferBonnin?

(gif of a card in Unified Canary with Desert contrast theme, hovering and un-hovering over the "more actions" menu button with mouse cursor)
unified-card-more-actions-button-desert-hc

@ghost ghost added status: needs attention The author has provided additional feedback and now requires attention. and removed status: needs author feedback This issue requires additional information from the issue author. labels Jun 10, 2022
@ferBonnin
Copy link
Contributor

@lisli1 does this issue ( the more actions button not appearing until hover) repros in production? If yes, then I am ok with filing a different bug and closing this one (as it would not have been introduced by any of these fixes) 🙂

@ferBonnin ferBonnin removed the status: needs attention The author has provided additional feedback and now requires attention. label Jun 10, 2022
@lisli1
Copy link
Contributor Author

lisli1 commented Jun 10, 2022

This issue does not repro in Unified Production 2021.518.3. Will close out this bug and file a new one. Thanks!

@lisli1
Copy link
Contributor Author

lisli1 commented Jun 10, 2022

Filed #5614 to track the new issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working status: resolved This issue has been merged into main and deployed to canary.
Projects
None yet
Development

No branches or pull requests

5 participants