Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSON export, missingHeadings and WCAG numbers #5746

Closed
etoscano opened this issue Jul 14, 2022 · 8 comments
Closed

JSON export, missingHeadings and WCAG numbers #5746

etoscano opened this issue Jul 14, 2022 · 8 comments
Labels
bug Something isn't working good first issue Good for newcomers status: needs author feedback This issue requires additional information from the issue author. status: no recent activity This issue requires additional information from the author, but hasn't been updated recently. status: resolved This issue has been merged into main and deployed to canary.

Comments

@etoscano
Copy link

I am looking at the JSON export of Accessibility Insights For Web and I see that "requirementKey": "missingHeadings" is connected to
"wcagNumber": "1.3.1" "wcagName": "Info and Relationships"
and to
"wcagNumber": "2.4.1" "wcagName": "Bypass Blocks"

However, when I read the information regarding test 5.2 No missing headings, this test is connected to 1.3.1: Info and Relationships and 2.4.6: Headings and Labels, and not to 2.4.1 Bypass Blocks.
@etoscano etoscano added the bug Something isn't working label Jul 14, 2022
@ghost ghost added the status: new This issue is new and requires triage by DRI. label Jul 14, 2022
@ghost ghost assigned JGibson2019 Jul 14, 2022
@JGibson2019
Copy link
Contributor

Hi @etoscano can you provide the link to the website you're testing with so we can investigate/attempt to repro on our end?

@JGibson2019 JGibson2019 added status: needs author feedback This issue requires additional information from the issue author. and removed status: new This issue is new and requires triage by DRI. labels Jul 14, 2022
@ghost
Copy link

ghost commented Jul 14, 2022

The team requires additional author feedback; please review their replies and update this issue accordingly. Thank you for contributing to Accessibility Insights!

@ferBonnin
Copy link
Contributor

Hi @etoscano can you provide the link to the website you're testing with so we can investigate/attempt to repro on our end?

@JGibson2019 I don't think we need a link to a website as this repos with any site when exporting as JSON.

@ferBonnin ferBonnin added the status: ready for triage This issue is ready to be triaged by the Accessibility Insights team. label Jul 15, 2022
@ghost ghost assigned ferBonnin Jul 15, 2022
@ghost
Copy link

ghost commented Jul 15, 2022

This issue has been marked as ready for team triage; we will triage it in our weekly review and update the issue. Thank you for contributing to Accessibility Insights!

@ghost ghost removed the status: needs author feedback This issue requires additional information from the issue author. label Jul 15, 2022
@ferBonnin ferBonnin added good first issue Good for newcomers status: ready for work This issue is ready to be worked on. and removed status: ready for triage This issue is ready to be triaged by the Accessibility Insights team. labels Jul 25, 2022
@ghost ghost added the help wanted Extra attention is needed label Jul 25, 2022
@lisli1 lisli1 mentioned this issue Jul 26, 2022
Merged
5 tasks
@lisli1
Copy link
Contributor

lisli1 commented Jul 26, 2022

@etoscano, thanks for using Accessibility Insights for Web and catching this issue! The "missingHeadings" test should point to WCAG 1.3.1 and 2.4.6. We will fix the discrepancy in the JSON export data.

lisli1 added a commit that referenced this issue Jul 26, 2022
@lisli1
fix: NoMissingHeadings test guidance link (#5803)
c7a5801 
Details
Change guidance link for NoMissingHeadings test from WCAG 2.4.1 to WCAG 2.4.6

Motivation
Addresses #5746

Context
Tested in dev build when exporting JSON. missingHeadings test is listed under WCAG 2.4.6, where it was previously listed under WCAG 2.4.1
@lisli1 lisli1 added the status: resolved This issue has been merged into main and deployed to canary. label Jul 26, 2022
@ghost ghost removed the status: ready for work This issue is ready to be worked on. label Jul 26, 2022
@lisli1
Copy link
Contributor

lisli1 commented Jul 29, 2022

@etoscano, the fix is now live in Canary Version 2022.7.27.1622. At your earliest convenience, please verify that the issue has been resolved.

@ferBonnin ferBonnin added the status: needs author feedback This issue requires additional information from the issue author. label Aug 2, 2022
@ghost
Copy link

ghost commented Aug 2, 2022

The team requires additional author feedback; please review their replies and update this issue accordingly. Thank you for contributing to Accessibility Insights!

@ghost ghost added the status: no recent activity This issue requires additional information from the author, but hasn't been updated recently. label Aug 6, 2022
@ghost
Copy link

ghost commented Aug 6, 2022

This issue has been automatically marked as stale because it is marked as requiring author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment. Thank you for contributing to Accessibility Insights!

@ghost ghost closed this as completed Aug 9, 2022
@DaveTryon DaveTryon removed the help wanted Extra attention is needed label Apr 27, 2023
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers status: needs author feedback This issue requires additional information from the issue author. status: no recent activity This issue requires additional information from the author, but hasn't been updated recently. status: resolved This issue has been merged into main and deployed to canary.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@ferBonnin @JGibson2019 @DaveTryon @etoscano @lisli1