Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: enable updates on mac for the unified client #2153

Merged
merged 49 commits into from
Feb 12, 2020
Merged

fix: enable updates on mac for the unified client #2153

merged 49 commits into from
Feb 12, 2020

Conversation

karanbirsingh
Copy link
Contributor

@karanbirsingh karanbirsingh commented Feb 12, 2020 •
edited
Loading

Description of changes

This PR enables updates for the macOS electron product. High level changes include:

Pull request checklist

  • Addresses an existing issue: #0000
  • Ran yarn fastpass
  • Added/updated relevant unit test(s) (and ran yarn test)
  • Verified code coverage for the changes made. Check coverage report at: <rootDir>/test-results/unit/coverage
  • PR title AND final merge commit title both start with a semantic tag (fix:, chore:, feat(feature-name):, refactor:). Check workflow guide at: <rootDir>/docs/workflow.md
  • (UI changes only) Added screenshots/GIFs to description above
  • (UI changes only) Verified usability with NVDA/JAWS

@karanbirsingh
try removing pkg file
f8250d7
@karanbirsingh
restrict to mac
890ff15
@karanbirsingh
move to parameter
ff2138e
@karanbirsingh
use mac variable
2a946bf
@karanbirsingh
try os agent
7845353
@karanbirsingh
install 7z explicitly
ff2312b
@karanbirsingh
try script
1d82bd5
@karanbirsingh
wrong script was invoked
9b7ad6c
@karanbirsingh
just mac pipeline for testing
f262a92
@karanbirsingh
change worknig directory before executing 7z
50758d2
@karanbirsingh
create zip ourselves
cf5707b
@karanbirsingh
remove zip from electron builder targets
cbed681
@karanbirsingh
update path to script and remove e2e tests
d52e404
@karanbirsingh
fix typo
3fed660
@karanbirsingh
only zip mac folder
ec4f8f1
@karanbirsingh
change back to exe
a355e4a
@karanbirsingh
pull from mac branch artifacts
e05d4c5
@karanbirsingh
target zip agian
8f39f78
@karanbirsingh
remove optional size and blockmapsize properties
11396be
@karanbirsingh
update 7z scripts to remove wrapper dependency, move zipping into grunt
b47b2c5
@karanbirsingh
update latest file based on platform
f0b6e3e
@karanbirsingh
rename update checksum to update yaml
3ea624f
@karanbirsingh
rename update checksum to update yaml
fb5e7e1
@karanbirsingh
rename update checksum to update yaml
7a2ddbf
@karanbirsingh
restore e2e test
3716873
@karanbirsingh
restore multiple platforms
91e3f18
@karanbirsingh
add missing import
5d7908f
@karanbirsingh
redirect stdio
55cae8e
@karanbirsingh
try cwd instead of cd
fc9e5e3
@karanbirsingh
quotes so spaces work in command line
430be35
@karanbirsingh
add cwd
b18bdb6
@karanbirsingh
w recursive param
fde684a
@karanbirsingh
npm workaround
91f4784
@karanbirsingh
yarnrc as well
b848da6
@karanbirsingh
try npx instead of yarn
7ad4108
@karanbirsingh
Revert zipping to use wrapper library (worked in prior build)to help …
ac40199 
…isolate what needs to change
@karanbirsingh
fix size reference and add better error handling
6c46f95
@karanbirsingh
add parentDir to resolve request
711dfcb
@karanbirsingh
add process.exit
4665f1b
@karanbirsingh
Revert "Revert zipping to use wrapper library (worked in prior build)…
d6d395f 
…to help isolate what needs to change"

This reverts commit ac40199.
@karanbirsingh
Remove workaround for npm package outage
3ee299d
@karanbirsingh
use master as trigger
382b654
@karanbirsingh
add comments and remove unnecessary complexity (direct node instead o…
be7508e 
…f yarn, multiple ways to specify platform, etc
@karanbirsingh
switch missed instance of yarn script to direct node call
fd73914
@karanbirsingh
Temporarily build from mac branch instead of master
e0c1cd7
@karanbirsingh
use parameter instead of agent OS to make build more platform agnostic
d89d927
@karanbirsingh
removing pkg file since signing service no longer seems to modify dow…
6f8ed7f 
…nload size
@karanbirsingh
Merge branch 'mac' of https://github.com/microsoft/accessibility-insi…
6bdb6ad 
…ghts-web into mac2
@karanbirsingh karanbirsingh requested a review from a team as a code owner February 12, 2020 22:29
@dbjorge dbjorge merged commit a914300 into master Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbjorge dbjorge dbjorge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@karanbirsingh @dbjorge