Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: import missing color-definitions #2485

Merged
merged 1 commit into from
Apr 13, 2020
Merged

tools: import missing color-definitions #2485

merged 1 commit into from
Apr 13, 2020

Conversation

smoralesd
Copy link
Contributor

@smoralesd smoralesd commented Apr 13, 2020 •
edited
Loading

Description of changes

Adding the missing color-definitions.scss import to debug-tools.scss to fix some stylings on the debug tools page.

Before
image

After
02 - after (fixed)

Notes
There is still not full support for high contrast mode on the debug tools, so with this change, the heart icon will change accordingly to high contrast, but the background will stay the same.

Pull request checklist

  • Addresses an existing issue: #0000
  • Ran yarn fastpass
  • Added/updated relevant unit test(s) (and ran yarn test)
  • Verified code coverage for the changes made. Check coverage report at: <rootDir>/test-results/unit/coverage
  • PR title AND final merge commit title both start with a semantic tag (fix:, chore:, feat(feature-name):, refactor:). See CONTRIBUTING.md.
  • (UI changes only) Added screenshots/GIFs to description above
  • (UI changes only) Verified usability with NVDA/JAWS

@smoralesd smoralesd requested a review from a team as a code owner April 13, 2020 16:35
waabid
waabid approved these changes Apr 13, 2020
View reviewed changes
Copy link
Member

@waabid waabid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smoralesd smoralesd merged commit e822707 into microsoft:master Apr 13, 2020
@smoralesd smoralesd deleted the debug-tools-styles branch April 13, 2020 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waabid waabid waabid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smoralesd @waabid