Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: text change to pointer/motion short description (not just *touch* or motion) #2652

Merged
merged 1 commit into from
May 11, 2020
Merged

fix: text change to pointer/motion short description (not just *touch* or motion) #2652

merged 1 commit into from
May 11, 2020

Conversation

patrickhlauke
Copy link
Contributor

Clarify that it's not just touch or motion, but that pointer includes all forms of pointers (mouse, touch, stylus)

Pull request checklist

  • [n/a] Addresses an existing issue: #0000
  • [n/a] Ran yarn fastpass
  • [n/a] Added/updated relevant unit test(s) (and ran yarn test)
  • [n/a] Verified code coverage for the changes made. Check coverage report at: <rootDir>/test-results/unit/coverage
  • PR title AND final merge commit title both start with a semantic tag (fix:, chore:, feat(feature-name):, refactor:). See CONTRIBUTING.md.
  • [n/a] (UI changes only) Added screenshots/GIFs to description above
  • [n/a] (UI changes only) Verified usability with NVDA/JAWS

@patrickhlauke
fix: text change to pointer/motion short description (not just *touch…
bbd7fe9 
…* or motion)

Clarify that it's not just touch or motion, but that pointer includes all forms of pointers (mouse, touch, stylus)
@patrickhlauke patrickhlauke requested a review from a team as a code owner May 10, 2020 10:04
LiLoDavis
LiLoDavis reviewed May 11, 2020
View reviewed changes
Copy link

@LiLoDavis LiLoDavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a good clarification to me.

@dbjorge dbjorge merged commit 85ddece into microsoft:master May 11, 2020
@dbjorge
Copy link
Contributor

dbjorge commented May 11, 2020

Thanks for the contribution, Patrick!

@patrickhlauke patrickhlauke deleted the pointer-motion-text-tweak branch August 27, 2020 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LiLoDavis LiLoDavis LiLoDavis left review comments

@dbjorge dbjorge dbjorge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@patrickhlauke @dbjorge @LiLoDavis