Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(nav-bar-content): adding requirement table section #2681

Merged
merged 1 commit into from
May 14, 2020
Merged

feat(nav-bar-content): adding requirement table section #2681

merged 1 commit into from
May 14, 2020

Conversation

waabid
Copy link
Member

@waabid waabid commented May 14, 2020

Description of changes

Refactors renderTable in test-step-view to a separate component for the new reflow UI.

Pull request checklist

  • [.] Addresses an existing issue: #0000
  • Ran yarn fastpass
  • Added/updated relevant unit test(s) (and ran yarn test)
  • Verified code coverage for the changes made. Check coverage report at: <rootDir>/test-results/unit/coverage
  • PR title AND final merge commit title both start with a semantic tag (fix:, chore:, feat(feature-name):, refactor:). See CONTRIBUTING.md.
  • [.] (UI changes only) Added screenshots/GIFs to description above
  • [.] (UI changes only) Verified usability with NVDA/JAWS

@waabid waabid requested a review from a team as a code owner May 14, 2020 20:58
@waabid waabid merged commit 7d59286 into microsoft:master May 14, 2020
@waabid waabid deleted the requirementTableSection branch January 27, 2022 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JGibson2019 JGibson2019 JGibson2019 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@waabid @JGibson2019