Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add e2e tests for new Landmarks auto-pass behavior #2685

Merged
merged 6 commits into from
May 15, 2020

Conversation

dbjorge
Copy link
Contributor

@dbjorge dbjorge commented May 14, 2020

Description of changes

Adds new end to end tests that verify the auto-pass-on-no-landmarks behavior introduced in #2644. Updates the product code to add a new data-automation-id, no UI impact.

Pull request checklist

  • Addresses an existing issue: e2e test for behavior in Landmarks requirements confusing for target page with no (or multiple) main landmarks #2521
  • Ran yarn fastpass
  • Added/updated relevant unit test(s) (and ran yarn test)
  • Verified code coverage for the changes made. Check coverage report at: <rootDir>/test-results/unit/coverage
  • PR title AND final merge commit title both start with a semantic tag (fix:, chore:, feat(feature-name):, refactor:). See CONTRIBUTING.md.
  • [n/a] (UI changes only) Added screenshots/GIFs to description above
  • [n/a] (UI changes only) Verified usability with NVDA/JAWS

@dbjorge dbjorge requested a review from a team as a code owner May 14, 2020 23:00
@dbjorge dbjorge merged commit 13eb1b5 into microsoft:master May 15, 2020
@dbjorge dbjorge deleted the landmark-e2es branch May 15, 2020 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants