Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(mobile-rules-guidance): update common components to use LinkComponent #2686

Merged
merged 7 commits into from
May 15, 2020
Merged

feat(mobile-rules-guidance): update common components to use LinkComponent #2686

merged 7 commits into from
May 15, 2020

Conversation

haonliu
Copy link
Contributor

@haonliu haonliu commented May 14, 2020 •
edited
Loading

Description of changes

update components to use LinkComponent so that in electron links will open in a new browser window.

Pull request checklist

  • Addresses an existing issue: #0000
  • Ran yarn fastpass
  • Added/updated relevant unit test(s) (and ran yarn test)
  • Verified code coverage for the changes made. Check coverage report at: <rootDir>/test-results/unit/coverage
  • PR title AND final merge commit title both start with a semantic tag (fix:, chore:, feat(feature-name):, refactor:). See CONTRIBUTING.md.
  • (UI changes only) Added screenshots/GIFs to description above
  • (UI changes only) Verified usability with NVDA/JAWS

@haonliu haonliu requested a review from a team as a code owner May 14, 2020 23:43
dbjorge
dbjorge suggested changes May 15, 2020
View reviewed changes
Copy link
Contributor

@dbjorge dbjorge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just 1 comment (plus the fastpass failures from the build)

@haonliu haonliu requested a review from dbjorge May 15, 2020 01:37
@haonliu haonliu merged commit 4c7d0e5 into microsoft:master May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobGallo RobGallo RobGallo approved these changes

@dbjorge dbjorge dbjorge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@haonliu @dbjorge @RobGallo