Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(nav-bar-content): add guidance icon to getting started view #2716

Merged
merged 5 commits into from
May 19, 2020
Merged

feat(nav-bar-content): add guidance icon to getting started view #2716

merged 5 commits into from
May 19, 2020

Conversation

lisli1
Copy link
Contributor

@lisli1 lisli1 commented May 19, 2020

Description of changes

  • Added guidance icon to title in GettingStartedView
  • Added GettingStartedView styles

Screenshot of Getting Started view for Headings test
image

Pull request checklist

  • Partially addresses an existing issue: # 1659964
  • Ran yarn fastpass
  • Added/updated relevant unit test(s) (and ran yarn test)
  • Verified code coverage for the changes made. Check coverage report at: <rootDir>/test-results/unit/coverage
  • PR title AND final merge commit title both start with a semantic tag (fix:, chore:, feat(feature-name):, refactor:). See CONTRIBUTING.md.
  • (UI changes only) Added screenshots/GIFs to description above
  • [n/a] (UI changes only) Verified usability with NVDA/JAWS

@lisli1 lisli1 requested a review from a team as a code owner May 19, 2020 00:16
pownkel
pownkel approved these changes May 19, 2020
View reviewed changes
Copy link
Contributor

@pownkel pownkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lisli1 lisli1 merged commit a737f46 into microsoft:master May 19, 2020
@lisli1 lisli1 deleted the lisli1/add-guidance-icon-to-getting-started-view branch July 21, 2021 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pownkel pownkel pownkel approved these changes

@waabid waabid waabid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lisli1 @waabid @pownkel