Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: create nav link renderer #2743

Merged
merged 3 commits into from
May 27, 2020
Merged

refactor: create nav link renderer #2743

merged 3 commits into from
May 27, 2020

Conversation

waabid
Copy link
Member

@waabid waabid commented May 21, 2020

Description of changes

There are a bunch of render functions within the left-nav-builder that I've refactored to a new class.

Pull request checklist

  • [n/a] Addresses an existing issue: #0000
  • Ran yarn fastpass
  • Added/updated relevant unit test(s) (and ran yarn test)
  • Verified code coverage for the changes made. Check coverage report at: <rootDir>/test-results/unit/coverage
  • PR title AND final merge commit title both start with a semantic tag (fix:, chore:, feat(feature-name):, refactor:). See CONTRIBUTING.md.
  • [n/a] (UI changes only) Added screenshots/GIFs to description above
  • [n/a] (UI changes only) Verified usability with NVDA/JAWS

@waabid waabid requested a review from a team as a code owner May 21, 2020 20:03
@waabid waabid merged commit eed6dcf into microsoft:master May 27, 2020
@waabid waabid deleted the navLinkRenderer branch January 27, 2022 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbjorge dbjorge dbjorge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@waabid @dbjorge